Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 117354 - Consistency for fixed facets
Summary: Consistency for fixed facets
Status: CLOSED DUPLICATE of bug 115346
Alias: None
Product: WTP Common Tools
Classification: WebTools
Component: wst.common (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Konstantin Komissarchik CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-21 14:41 EST by Tim deBoer CLA
Modified: 2005-12-13 10:17 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tim deBoer CLA 2005-11-21 14:41:41 EST
We've talked before that making facets bold is inconsistent with other places in the UI and isn't evident to the user why it is bold. I finally remembered several other places in the UI that have a similar purpose.

The following preferences pages have fixed/uneditable objects in a table with a yellowish background. For consistency I think we should make the facets UI match. Very little code is required - see org.eclipse.wst.server.ui.internal.viewers.LockedCheckboxTableViewer for an example.

Examples:
 * Java > Build Path > Classpath Variables (also puts the word 'reserved' in brackets after the ones that can't be changed)
 * Java > Debug > Logical Structures
 * Server > Installed Runtimes (WTP doesn't ship with any 'locked' servers, but they can appear in stack products)
Comment 1 Nitin Dahyabhai CLA 2005-11-21 15:13:19 EST
Is the WebDoclet option really independent of the Dynamic Web Module and Java Facets?  Isn't a checkbox typically greyed or disabled if it's not meant to be togglable?
Comment 2 Tim deBoer CLA 2005-11-21 15:57:44 EST
Grayed out/disabling would be another option, but I'm not sure it would work since in many of these cases you can still change the version of the facet - disabling would make it look like the user can't do that or actually block them from doing it.
Comment 3 Konstantin Komissarchik CLA 2005-11-24 11:49:22 EST

*** This bug has been marked as a duplicate of 115346 ***
Comment 4 Tim deBoer CLA 2005-12-13 10:17:30 EST
Verified.