Bug 116034 - [misc] Opening text editor on non-text content gives CoreException
Summary: [misc] Opening text editor on non-text content gives CoreException
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.2   Edit
Hardware: PC All
: P2 major (vote)
Target Milestone: 3.1.2   Edit
Assignee: Dani Megert CLA Friend
QA Contact:
URL:
Whiteboard:
Keywords:
: 98557 108297 115798 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-11-11 11:33 EST by Tobias Widmer CLA Friend
Modified: 2006-01-10 07:24 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Widmer CLA Friend 2005-11-11 11:33:01 EST
I20051108-1011

Steps to reproduce:
- Register your own content type for file name "foo.bar" in plugin.xml
- Do not inherit from text content type
- Create new file "foo.bar" in runtime workbench
- Open file

The following exception occurs:

org.eclipse.core.runtime.CoreException: Cannot create file buffer.
	at org.eclipse.core.internal.filebuffers.TextFileBufferManager.connect
(TextFileBufferManager.java:105)
	at org.eclipse.ui.editors.text.TextFileDocumentProvider.createFileInfo
(TextFileDocumentProvider.java:548)
	at org.eclipse.ui.editors.text.TextFileDocumentProvider.connect
(TextFileDocumentProvider.java:469)
	at org.eclipse.ui.texteditor.AbstractTextEditor.doSetInput
(AbstractTextEditor.java:3023)
	at org.eclipse.ui.texteditor.StatusTextEditor.doSetInput
(StatusTextEditor.java:173)
	at org.eclipse.ui.texteditor.AbstractDecoratedTextEditor.doSetInput
(AbstractDecoratedTextEditor.java:1376)
	at org.eclipse.ui.editors.text.TextEditor.doSetInput
(TextEditor.java:262)
	at org.eclipse.ui.texteditor.AbstractTextEditor$17.run
(AbstractTextEditor.java:2375)
	at org.eclipse.jface.operation.ModalContext.runInCurrentThread
(ModalContext.java:346)
	at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:291)
	at org.eclipse.jface.window.ApplicationWindow$1.run
(ApplicationWindow.java:631)
	at org.eclipse.swt.custom.BusyIndicator.showWhile
(BusyIndicator.java:69)
	at org.eclipse.jface.window.ApplicationWindow.run
(ApplicationWindow.java:628)
	at org.eclipse.ui.internal.WorkbenchWindow.run
(WorkbenchWindow.java:2133)
	at org.eclipse.ui.texteditor.AbstractTextEditor.internalInit
(AbstractTextEditor.java:2393)
	at org.eclipse.ui.texteditor.AbstractTextEditor.init
(AbstractTextEditor.java:2420)
	at org.eclipse.ui.internal.EditorManager.createSite
(EditorManager.java:763)
	at org.eclipse.ui.internal.EditorReference.createPartHelper
(EditorReference.java:585)
	at org.eclipse.ui.internal.EditorReference.createPart
(EditorReference.java:374)
	at org.eclipse.ui.internal.WorkbenchPartReference.getPart
(WorkbenchPartReference.java:552)
	at org.eclipse.ui.internal.PartPane.setVisible(PartPane.java:285)
	at org.eclipse.ui.internal.presentations.PresentablePart.setVisible
(PresentablePart.java:140)
	at 
org.eclipse.ui.internal.presentations.util.PresentablePartFolder.select
(PresentablePartFolder.java:263)
	at 
org.eclipse.ui.internal.presentations.util.LeftToRightTabOrder.select
(LeftToRightTabOrder.java:65)
	at 
org.eclipse.ui.internal.presentations.util.TabbedStackPresentation.selectPart
(TabbedStackPresentation.java:394)
	at org.eclipse.ui.internal.PartStack.refreshPresentationSelection
(PartStack.java:1130)
	at org.eclipse.ui.internal.PartStack.setSelection(PartStack.java:1083)
	at org.eclipse.ui.internal.PartStack.showPart(PartStack.java:1288)
	at org.eclipse.ui.internal.PartStack.add(PartStack.java:453)
	at org.eclipse.ui.internal.EditorStack.add(EditorStack.java:101)
	at org.eclipse.ui.internal.PartStack.add(PartStack.java:440)
	at org.eclipse.ui.internal.EditorStack.add(EditorStack.java:110)
	at org.eclipse.ui.internal.EditorSashContainer.addEditor
(EditorSashContainer.java:60)
	at org.eclipse.ui.internal.EditorAreaHelper.addToLayout
(EditorAreaHelper.java:214)
	at org.eclipse.ui.internal.EditorAreaHelper.addEditor
(EditorAreaHelper.java:204)
	at org.eclipse.ui.internal.EditorManager.createEditorTab
(EditorManager.java:743)
	at org.eclipse.ui.internal.EditorManager.openEditorFromDescriptor
(EditorManager.java:650)
	at org.eclipse.ui.internal.EditorManager.openEditor
(EditorManager.java:613)
	at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditorBatched
(WorkbenchPage.java:2380)
	at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditor
(WorkbenchPage.java:2315)
	at org.eclipse.ui.internal.WorkbenchPage.access$10
(WorkbenchPage.java:2307)
	at org.eclipse.ui.internal.WorkbenchPage$9.run(WorkbenchPage.java:2293)
	at org.eclipse.swt.custom.BusyIndicator.showWhile
(BusyIndicator.java:69)
	at org.eclipse.ui.internal.WorkbenchPage.openEditor
(WorkbenchPage.java:2288)
	at org.eclipse.ui.internal.WorkbenchPage.openEditor
(WorkbenchPage.java:2269)
	at org.eclipse.ui.ide.IDE.openEditor(IDE.java:372)
	at org.eclipse.ui.ide.IDE.openEditor(IDE.java:335)
	at org.eclipse.ui.actions.OpenFileAction.openFile
(OpenFileAction.java:98)
	at org.eclipse.ui.actions.OpenSystemEditorAction.run
(OpenSystemEditorAction.java:98)
	at org.eclipse.ui.views.navigator.OpenActionGroup.runDefaultAction
(OpenActionGroup.java:120)
	at org.eclipse.ui.views.navigator.MainActionGroup.runDefaultAction
(MainActionGroup.java:315)
	at org.eclipse.ui.views.navigator.ResourceNavigator.handleOpen
(ResourceNavigator.java:650)
	at org.eclipse.ui.views.navigator.ResourceNavigator$6.open
(ResourceNavigator.java:409)
	at org.eclipse.jface.viewers.StructuredViewer$2.run
(StructuredViewer.java:741)
	at org.eclipse.core.internal.runtime.InternalPlatform.run
(InternalPlatform.java:1044)
	at org.eclipse.core.runtime.Platform.run(Platform.java:783)
	at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:44)
	at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:148)
	at org.eclipse.jface.viewers.StructuredViewer.fireOpen
(StructuredViewer.java:739)
	at org.eclipse.jface.viewers.StructuredViewer.handleOpen
(StructuredViewer.java:968)
	at org.eclipse.jface.viewers.StructuredViewer$6.handleOpen
(StructuredViewer.java:1067)
	at org.eclipse.jface.util.OpenStrategy.fireOpenEvent
(OpenStrategy.java:244)
	at org.eclipse.jface.util.OpenStrategy.access$2(OpenStrategy.java:239)
	at org.eclipse.jface.util.OpenStrategy$1.handleEvent
(OpenStrategy.java:278)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:896)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3240)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2860)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1786)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1750)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench
(Workbench.java:378)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:143)
	at org.eclipse.ui.internal.ide.IDEApplication.run
(IDEApplication.java:106)
	at org.eclipse.core.internal.runtime.PlatformActivator$1.run
(PlatformActivator.java:226)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run
(EclipseStarter.java:376)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run
(EclipseStarter.java:165)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:585)
	at org.eclipse.core.launcher.Main.invokeFramework(Main.java:338)
	at org.eclipse.core.launcher.Main.basicRun(Main.java:282)
	at org.eclipse.core.launcher.Main.run(Main.java:977)
	at org.eclipse.core.launcher.Main.main(Main.java:952)

Either do not offer to open file in text editor or provide a buffer anyway.
Comment 1 Dani Megert CLA Friend 2005-11-22 09:04:01 EST
Fixed in HEAD.
Available in builds > I20051122-0800.

Will backport 3.1.2.
Comment 2 Dani Megert CLA Friend 2005-11-22 09:04:54 EST
*** Bug 115798 has been marked as a duplicate of this bug. ***
Comment 3 Dani Megert CLA Friend 2005-11-22 09:14:43 EST
*** Bug 98557 has been marked as a duplicate of this bug. ***
Comment 4 Dani Megert CLA Friend 2005-11-22 09:24:54 EST
*** Bug 108297 has been marked as a duplicate of this bug. ***
Comment 5 Dani Megert CLA Friend 2005-11-22 10:21:16 EST
Released into 3.1.2.
Comment 6 Markus Keller CLA Friend 2006-01-10 07:24:23 EST
Verified in M20060109-1200.