Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 115785 - Quick dialogs don't appear after having used the menu
Summary: Quick dialogs don't appear after having used the menu
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P2 major (vote)
Target Milestone: 3.2 M4   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 110937
  Show dependency tree
 
Reported: 2005-11-10 04:52 EST by Markus Keller CLA
Modified: 2005-12-13 15:13 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2005-11-10 04:52:23 EST
I20051108-1011

- in a java editor, press Ctrl+O, and then click the Menu button
- [optional] choose 'Remember Size and Location'
- click somewhere in the workbench window (not into the quick dialog)
-> from now on, Ctrl+T and Ctrl+O don't work for the editor
Comment 1 Dani Megert CLA 2005-11-10 06:12:41 EST
Regression added switching to the new PopupDialog (works in 3.2 M3) in
AbstractInformationControl 1.30.

Can reproduce on WinXP but work on Linux-GTK.
Might be related to bug 110937.
Comment 2 Dani Megert CLA 2005-11-10 06:19:05 EST
I've released a quick fix into our code which forces to close the dialog.

The real bug is in PopupDialog:

	shell.addListener(SWT.Deactivate, new Listener() {
		public void handleEvent(Event event) {
			if (listenToDeactivate) {
				close();
			}
		}
	});

At the time when the user clicks somewhere else than the PopupDialog while the
menu was activate 'listenToDeactivate' is still false and hence the dialog does
not close. Clicking outside the PopupDialog must behave the same (i.e. close)
when doing this directly from the dialog or when doing this while the view menu
is active.

Note that Platform's send different events and/or have different event ordering
when opening that menu.
Comment 3 Susan McCourt CLA 2005-11-10 15:44:31 EST
I'm getting ready to leave town for a long weekend.  Given you have a 
workaround I'll look into this first thing Monday.
Comment 4 Susan McCourt CLA 2005-11-21 21:28:37 EST
I'm sorry - I let this bug fall through the cracks last week.
Released a fix >20051121.  It will make the 1122 N-build, but not the I-build.
Tested it by loading the previous version of AbstractInformationControl (without the workaround), and running the scenario on windows, Mac, and Linux/GTK.
Comment 5 Susan McCourt CLA 2005-11-21 21:33:52 EST
Clarification - the released fix will work with the current AbstractInformationControl workaround, as well as without the workaround.  Dani, you are free to remove your workaround at your leisure.
Comment 6 Dani Megert CLA 2005-11-22 03:35:11 EST
Thanks, Susan. I'll pull out the workaround directly after the I-build.
Comment 7 Dani Megert CLA 2005-11-24 04:56:33 EST
Pulled out workaround from AbstractInformationControl.java
Available in builds > N20051124-0010.
Comment 8 Susan McCourt CLA 2005-12-13 15:13:38 EST
verified I20051213-0100, Win XP, following the steps described in comment #0