Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 114702 - Remove legacy IBM/Rational comment/string references.
Summary: Remove legacy IBM/Rational comment/string references.
Status: CLOSED DUPLICATE of bug 182662
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P1 normal (vote)
Target Milestone: ---   Edit
Assignee: Samson Wai CLA
QA Contact:
URL:
Whiteboard: closed460
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-01 23:09 EST by Paul Slauenwhite CLA
Modified: 2016-05-05 10:53 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Slauenwhite CLA 2005-11-01 23:09:48 EST
Remove legacy IBM/Rational comment/string references.

The TPTP source code and resources (e.g. *.xsd, *.xml, *.html, *.exsd, 
*.properties, etc.) contains legacy IBM/Rational comment/string references 
including legacy copyright statements that should be removed for this component
unless required for backwards compatibility.  

Please use the following TPTP copyright statement:

/**********************************************************************
 * Copyright (c) 2005 IBM Corporation and others.
 * All rights reserved.   This program and the accompanying materials
 * are made available under the terms of the Eclipse Public License v1.0
 * which accompanies this distribution, and is available at
 * http://www.eclipse.org/legal/epl-v10.html
 * $Id$
 * 
 * Contributors: 
 * IBM - Initial API and implementation
 **********************************************************************/

Note:  The above TPTP copyright statement is for content contributed by 
committers work for IBM.  As such, the two references to 'IBM' should be 
swapped with references to the company that originally contributed the content.

Plug-ins containing the legacy IBM/Rational comment/string 'com.ibm':

org.eclipse.tptp.platform.collection.framework

Note:  There is no report that shows these results.  They have been derived 
from searching all files (e.g. *.*) in the above TPTP plugins for the 'Property 
of IBM' 
and 'com.ibm' strings.
Comment 1 Sri Doddapaneni CLA 2005-11-02 13:36:02 EST
Deferred from 4.1 as per decision made at Platform project meeting (11/2/05)
Comment 2 Karla Callaghan CLA 2006-03-07 17:33:36 EST
Hendra - I suspect all of the old copyright headers have been cleaned up by now with the regular use of the copyright scanning tool.

Please confirm and close this out.
Comment 3 Hendra Suwanda CLA 2006-04-11 09:47:56 EDT

*** This bug has been marked as a duplicate of 114700 ***
Comment 4 Paul Slauenwhite CLA 2006-04-17 17:14:31 EDT
Still 24 references in the org.eclipse.tptp.platform.collection.framework plugin (Thread Analyzer).
Comment 5 Hendra Suwanda CLA 2006-04-24 12:42:50 EDT
Bob, please handle as discussed.  Thanks.
Comment 6 Sri Doddapaneni CLA 2006-06-07 12:57:19 EDT
Provide status update and if pending retarget to other than 4.2 I3.
Comment 7 Bob Duncan CLA 2006-06-07 17:57:45 EDT
The orginal copyright problem was taken care of previously and no longers exists. 

The remaining problem is the references to "com.ibm". Half of them are contained in comments (mostly as pruned imports) and could be easily removed. The other half, however, are class names that appear in strings referenced from various code sites. These are likely references from dead code but the exact extent of the dead code would have to be verified before it (or at least the "com.ibm" refs from within it) could be safely removed.

There is no pressing need to remove the "com.ibm" references for 4.2 GA. Therefore, with Paul's agreement, this is being retargeted to 4.3.
Comment 8 Bob Duncan CLA 2006-06-07 18:01:34 EDT
The background to this and the source of the dead code is as follows:

These "com.ibm" references occur in the o.e.h.collection.threadanalyzer package of the o.e.h.tptp.platform.collection.framework plugin. This is part of a unit of code that was contributed to Hyades after it had been reduced to a subset from the original larger unit of code. The subset contained functionality used  by a prototype (o.e.h.logging.jvm.threadanalysis package) that extracted thread stacks and monitors from coredumps of a certain app server (using the contributed subset) and converted them to a CBE representation. Obviously, given the remaining "com.ibm" references, the subset was not minimal and should have been. In addition, the entire protoype is of questionable use in TPTP now since the intended users are believed eventually to have abandoned it's use in favor of another scheme. 

In 4.3, either the o.e.h.logging.jvm.threadanalysis and o.e.h.collection.threadanalyzer packages will need to be prepared for withdrawal or the o.e.h.collection.threadanalyzer package will need to be pruned to eliminate the dead code containing the "com.ibm" references.
Comment 9 Bob Duncan CLA 2006-10-30 10:58:43 EST
Not containable in 4.3 and retargetting to 4.4 as per Oct 26 Platform Collection & Communication Meeting. This was of major or lower sev and never made the cut for a specific iteration over the life of 4.3.
Comment 10 jkubasta CLA 2007-04-18 07:27:37 EDT
Hi Samson,
The only references should be to com.ibm.icu.*.  Would you please look at the references to com.ibm.* in org.eclipse.tptp.platform.collection.framework.* and see if we can remove them.  Thanks.
Comment 11 Samson Wai CLA 2007-04-18 10:45:54 EDT
The "com.ibm.icu.*" packages are required by the monitoring and the test plugins and should not be removed.
Comment 12 jkubasta CLA 2007-04-18 11:08:42 EDT
I know.  It is the multiple references to com.ibm.ws.performance.* that need removing please.  
Comment 13 Samson Wai CLA 2007-04-18 11:50:46 EDT
I can only remove those comments which reference "com.ibm" but there are code which loads the "com.ibm" classes explicitly. These code is part of the core functionality of the thread analyzer so removing it might cause the whole plugin to stop working properly.

Is there a plan to remove this thread analyzer plugin? I am not aware of anyone using this at all. No bug has ever opened against this component.
Comment 14 jkubasta CLA 2007-04-19 20:27:22 EDT

*** This bug has been marked as a duplicate of bug 182662 ***
Comment 15 Paul Slauenwhite CLA 2009-07-02 13:52:13 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.