Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 114638 - Test Log Viewer: Verdict navigation toolbar buttons do not enable/disable correctly.
Summary: Test Log Viewer: Verdict navigation toolbar buttons do not enable/disable cor...
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Paul Slauenwhite CLA
QA Contact:
URL:
Whiteboard: closed461
Keywords:
: 210742 218794 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-11-01 15:34 EST by Bianca Jiang CLA
Modified: 2016-05-05 10:58 EDT (History)
4 users (show)

See Also:


Attachments
Patch. (2.02 KB, patch)
2008-07-10 16:15 EDT, Paul Slauenwhite CLA
no flags Details | Diff
Patch Part 2. (1.98 KB, patch)
2008-07-11 07:45 EDT, Paul Slauenwhite CLA
no flags Details | Diff
Patch Part 3. (21.27 KB, patch)
2008-07-11 09:44 EDT, Paul Slauenwhite CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bianca Jiang CLA 2005-11-01 15:34:31 EST
If Test log viewer is opened before the test finishes executing, the verdict 
navigation toolbar (enabled/disabled) status reflects the verdicts contained 
when the log is opened. While test log viewer refreshes when there's changes 
to the content of test log, toolbar status doesn't.
Comment 1 Bianca Jiang CLA 2005-11-01 15:35:04 EST
workaround is to close the Test log viewer and reopen it. Deferring to 4.2.
Comment 2 Paul Slauenwhite CLA 2007-01-17 09:19:24 EST
Sizing updated as provided by Bianaca.
Comment 3 Paul Slauenwhite CLA 2007-01-26 08:25:12 EST
Targeting to future since not containable in 4.4.
Comment 4 Paul Slauenwhite CLA 2007-01-26 09:01:27 EST
As discussed on this week's Test Project call (January 22, 2007), the Test Project will focus on existing P1 - P2/Blocker - Major and P1/Normal and test creation/automation defects (omitting defects dependant on outstanding features) in TPTP 4.4.  All other Test Project defects have been targeted to future.

If this defect has been targeted to future and you/originator feel it should be completed in 4.4, please provide the necessary reason as a reply to this comment or a post to the Test Project mailing list (tptp-test-tooling-dev@eclipse.org).  We will collectively triage and assess our resources to determine a case-by-case decision. 
Comment 5 Paul Slauenwhite CLA 2007-01-26 09:03:46 EST
Correction:  The Test Project mailing list is tptp-testing-tools-dev@eclipse.org.
Comment 6 Paul Slauenwhite CLA 2007-11-07 10:18:39 EST
Reassigning to the Project Lead.
Comment 7 Paul Slauenwhite CLA 2008-05-27 08:04:18 EDT
*** Bug 218794 has been marked as a duplicate of this bug. ***
Comment 8 Paul Slauenwhite CLA 2008-05-27 08:04:30 EDT
*** Bug 210742 has been marked as a duplicate of this bug. ***
Comment 9 Paul Slauenwhite CLA 2008-05-27 08:04:56 EDT
In addition:

[Defect #210742]
Log Viewer : navigation button on event part of test log are not enabled by default

Steps To Reproduce:
1.open a test log
2.navigation button on event part of test log are not enabled by default. they
only become enable when you use the "select" button

[Defect #218794]
The five toolbar buttons in test log are disabled after click some verdicts in event tree

There are five buttons in eventpage of test log:
Navigate to First
Navigate to Previous
Select the verdict type to navigate
Navigate to Next
Navigate to Last
when I open one execution file--events page, those buttons are enabled as long
as I don't click some verdict or message in events tree, after I click/expand
the tree by myself, the buttons become disabled

For the button: Selece the verdict type to navigate
the default value for that button is 'All' ,after I choose one type of
verdict(ie.'FAIL'), it will expand the tree contains the first 'FAIL' result,
and those buttons are still enabled as long as I don't click some verdict or
message in events tree, after I click/expand other tree by myself, the buttons
become disabled except the last 'FAIL' result expanded by buttons(navigate
to/first previous/nest/last)

no matter what you choose(or use default'All') in the button to select
verdict type, those 5 buttons are always disabled after you click/expand events
tree except you click the last result expanded by those navigating buttons
Comment 10 Paul Slauenwhite CLA 2008-07-09 15:59:48 EDT
See /org.eclipse.hyades.test.ui/src/org/eclipse/hyades/test/ui/forms/actions/VerdictTypesPullDownAction.java.
Comment 11 Paul Slauenwhite CLA 2008-07-10 16:14:12 EDT
Defect #218794 is a regression caused by the model scalability work recently completed in 4.4.0 (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=180986#c1).  As a result, the new query-based verdict navigation in Test Log Viewer (/org.eclipse.hyades.test.ui/src/org/eclipse/hyades/test/ui/forms/base/TestLogVerdictTraversalQuery.java) does not support navigating relative to a element selection (other than the current selected verdict event) in the event tree, despite the interface (/org.eclipse.hyades.test.ui/src/org/eclipse/hyades/test/ui/forms/util/ITestLogVerdictTraversal.java) defining such methods.  If the user changes selection from the current selected verdict event, they have to close/reopen the editor or reselect a new verdict type for the navigation buttons.
Comment 12 Paul Slauenwhite CLA 2008-07-10 16:15:19 EDT
Created attachment 107135 [details]
Patch.

Patch to fix disabling the verdict navigation buttons when there is no verdict in the test log (e.g. 'no verdict').

Patch checked in to CVS (HEAD).
Comment 13 Paul Slauenwhite CLA 2008-07-10 16:15:38 EDT
Hours worked for the first patch.
Comment 14 Paul Slauenwhite CLA 2008-07-11 07:45:30 EDT
Created attachment 107192 [details]
Patch Part 2.

Patch to fix disabling the verdict navigation buttons when there is no verdicts of the current type.
Comment 15 Paul Slauenwhite CLA 2008-07-11 08:26:50 EDT
(In reply to comment #14)
> Created an attachment (id=107192) [details]
> Patch Part 2.
> 
> Patch to fix disabling the verdict navigation buttons when there is no verdicts
> of the current type.
> 

Patch checked in to CVS (HEAD).
Comment 16 Paul Slauenwhite CLA 2008-07-11 08:29:41 EDT
(In reply to comment #0)
> If Test log viewer is opened before the test finishes executing, the verdict 
> navigation toolbar (enabled/disabled) status reflects the verdicts contained 
> when the log is opened. While test log viewer refreshes when there's changes 
> to the content of test log, toolbar status doesn't.

Handled under https://bugs.eclipse.org/bugs/show_bug.cgi?id=158284.
Comment 17 Paul Slauenwhite CLA 2008-07-11 09:44:33 EDT
Created attachment 107200 [details]
Patch Part 3.

Patch to fix the following:

-Enabled the verdict navigation buttons when the Test Log Viewer is first opened (opening the Events tab manually or from the links on the Overview tab) and verdicts events are selected in the event tree.  Since the TestLogVerdictTraversalQuery does not support iterating non-TPFVerdictEvent events, only the first/last navigation buttons will be enabled when non-verdicts events are selected in the event tree.

-Updated the verdict type drop-down to only change the verdict type, notify the listeners, and run the action when the verdict type has changed.

-Updated TestLogVerdictTraversalQuery.java to support navigation relative to a verdict element selection in the event tree.

-Commented the ITestLogVerdictTraversal.java interface.

Patch checked in to CVS (HEAD).
Comment 18 Paul Slauenwhite CLA 2008-07-11 09:47:05 EDT
Hours worked to create/test the last two patches.
Comment 19 Paul Slauenwhite CLA 2009-09-24 14:32:38 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.
Comment 20 Paul Slauenwhite CLA 2009-11-23 10:22:50 EST
Correcting component.