Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 114089 - [WorkingSets] Updater class for resource working sets
Summary: [WorkingSets] Updater class for resource working sets
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 M3   Edit
Assignee: Kim Horne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 15938 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-10-28 08:04 EDT by Dirk Baeumer CLA
Modified: 2005-12-02 11:33 EST (History)
3 users (show)

See Also:

Attachments
The patch created against I20051025-0800 (6.59 KB, patch)
2005-10-28 08:06 EDT, Dirk Baeumer CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Baeumer CLA 2005-10-28 08:04:28 EDT 
I20051025-0800

JDT is getting more and more requests that the package explorer is able to show
resource working sets as well as Java working sets.

I added some code to the package explorer that enables showing resource working
sets iff the top level elements of the working set are projects (otherwise it
will be difficult to ensure that we don't show the "same" element twice once as
a resource and once as a Java element).

The code is working however the correct updating of the package explorer depends
on having a working set updater installed. This is the case for Java working
sets but not for resource working sets.

Since Java working sets can show simple resources as well I simply extracted the
code to a ResourceWorkingSetUpdater which I would like to contribute to Platform/UI.

Nick, I have assigned the PR directly to you since you looked at the working set
 updater patches in 3.1.
Comment 1 Dirk Baeumer CLA 2005-10-28 08:06:15 EDT 
Created attachment 28913 [details]
The patch created against I20051025-0800
Comment 2 Dirk Baeumer CLA 2005-10-28 08:07:50 EDT 
CCing Michael since he is one asking for the feature (to use the working sets
created during "team import") and might be able to convince Nick to release the
code for M3 ;-)
Comment 3 Dirk Baeumer CLA 2005-10-28 08:08:35 EDT 
I am talking about showing resource working sets when the package explorer is in
Working Set mode.
Comment 4 Nick Edgar CLA 2005-10-28 09:15:56 EDT 
Kim, can you please review for M3?
Comment 5 Kim Horne CLA 2005-10-28 10:20:19 EDT 
Patch applied with a bit more javadoc to remove any warning markers.
Comment 6 Dirk Baeumer CLA 2005-10-28 10:53:26 EDT 
Thanks !!
Comment 7 Kim Horne CLA 2005-11-02 09:29:19 EST 
Verified in I20051101-1204 but I would appreciate a second opinion Dirk.
Comment 8 Dirk Baeumer CLA 2005-11-02 09:38:18 EST 
Verified on I20051102-0010 that working set updates correctly:

- on rename, move and delete
- and that working set references elements in closed projects don't loose
  there contents.
Comment 9 Kim Horne CLA 2005-12-02 11:33:56 EST 
*** Bug 15938 has been marked as a duplicate of this bug. ***