Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 113908 - FilteredTree - race condition when pressing Enter
Summary: FilteredTree - race condition when pressing Enter
Status: RESOLVED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC All
: P4 normal (vote)
Target Milestone: ---   Edit
Assignee: Karice McIntyre CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-26 18:14 EDT by Karice McIntyre CLA
Modified: 2007-01-18 16:07 EST (History)
3 users (show)

See Also:


Attachments
Screen shot of Thunderbird search field (3.97 KB, image/jpeg)
2005-11-03 10:29 EST, Nick Edgar CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Karice McIntyre CLA 2005-10-26 18:14:45 EDT
I opened this bug to track the remaining issues of bug 102081.  The original 
bug was just getting too much to keep track of.  There are a few lower priority 
issues left to consider with the FilteredTree changes:

1. make filtered tree work with categories (example, experimental Keys 
preference page)
2. identify other potential useful places to use a filtered tree (wizard 
selection pages, perhaps)
3. investigate race condition:
   + I believe there is a race condition between the refresh job and the 
effects of pressing enter.  It's possible that the refresh job has not yet run 
(in response to filter text changes) when the "enter" key is handled by the 
traverse listener.
Comment 1 Nick Edgar CLA 2005-11-03 10:29:02 EST
I think the instructions we provide in the text field could be improved too.
"type filter text" is ambiguous and speaks in terms of the implementation.

Some suggestions:
- "Type words to match here"
- in Mozilla Firefox, the Manage Bookmarks dialog has a text field labeled "Search:"
- in Mozilla Thunderbird, the search box at top right has a search icon (with
minimal extra graphic noise - see attachment)


Comment 2 Nick Edgar CLA 2005-11-03 10:29:28 EST
Created attachment 29268 [details]
Screen shot of Thunderbird search field
Comment 3 Karice McIntyre CLA 2006-01-17 16:34:49 EST
Doug, the issue you want addressed is 1.
Add to list:
4) make filtered tree API, including investigation of whether or not having a generic superclass with tree and list implementations is worthwhile.

Hmm, this is becoming a catch-all bug for general filtered tree issues.
The issue Nick brings up in comment #1 is now a separate bug 119985
Comment 4 Karice McIntyre CLA 2006-02-08 11:10:35 EST
Changes released for bug 74795 adresses issue 1.  Also, filtered tree has been added to wizard selection pages.  

The only remaining issue is the possible race condition so I am changing the title of the bug to reflect this.
Comment 5 Karice McIntyre CLA 2007-01-18 16:07:29 EST
Cannot reproduce the race condition is not reproducable.