Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 113864 - Add refactor actions back into XSD source page
Summary: Add refactor actions back into XSD source page
Status: CLOSED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.xsd (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 1.5.1 M151   Edit
Assignee: Trung CLA
QA Contact:
URL:
Whiteboard: reviewed_1.5
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-26 14:14 EDT by Amy Wu CLA
Modified: 2006-11-28 15:40 EST (History)
1 user (show)

See Also:


Attachments
patch for the new actions (66.17 KB, patch)
2005-11-30 14:47 EST, Ella Belisario CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Amy Wu CLA 2005-10-26 14:14:25 EDT
Due to fixing Bug 112884, the refactor actions were removed from the XSD source
page.  These actions need to be added back in.

I did some initial investigation into adding them back in via popup menu
extension point; however, I ran into some issues (mainly due to limitations in
base).  The actions can be added back in doing something like the following:

<viewerContribution
targetID="org.eclipse.wst.xsd.core.xsdsource.source.EditorContext"
	id="org.eclipse.wst.xsd.editorActions">
	<action
id="org.eclipse.wst.xsd.ui.internal.refactor.actions.MakeLocalElementGlobalActionDelegate"
		label="Make Local Element Global"
class="org.eclipse.wst.xsd.ui.internal.refactor.actions.MakeLocalElementGlobalActionDelegate"
		menubarPath="refactor.group" />
</viewerContribution>

But the actions will always be visible and enabled in the editor context menu. 
And then when the user tries to run the actions, they will get some sort of
notification that the action cannot be performed if it can't.  This is different
than the way these actions used to work.  The actions used to only be visible
and enabled when the actions were going to work.  I could not find a way to work
around this limitation, and it looks like that's how other actions work (that
were contributed via extension point).
Comment 1 Keith Chong CLA 2005-11-19 13:11:58 EST
Reassign
Comment 2 Ella Belisario CLA 2005-11-30 14:47:00 EST
Created attachment 30888 [details]
patch for the new actions
Comment 3 Craig Salter CLA 2006-06-06 16:26:16 EDT
Upping the priority.  I doubt this patch is still applicable.  Should be a trivial thing to fix though.
Comment 4 Craig Salter CLA 2006-06-07 16:11:15 EDT
We really should fix this.  The fix should be trivial and will allow folks who like working in the source view to do refactoring without needing to jump over to the outline or design view.  I'd like to put it forward as a WTP 1.5 candidate... but I expect that this will be pushed back to WTP 1.5.1.
Comment 5 Keith Chong CLA 2006-06-13 10:57:07 EDT
Retarget to 1.5.1
Comment 6 Trung CLA 2006-08-17 17:40:20 EDT
I have fixed this problem and I am having the patch for it. It's a really trivia one.
Should this be pushed back to WTP 1.5 ?
Comment 7 Trung CLA 2006-08-21 21:10:06 EDT
Patch has been commited, this bug is ready to be marked 'Resolved'
Comment 8 Keith Chong CLA 2006-08-24 12:00:19 EDT
Patch was committed.
Comment 9 Amy Wu CLA 2006-09-19 17:43:54 EDT
verified in wtp 1.5.1 9/14/06

I did find a new bug though, bug 157912.
Comment 10 John Lanuti CLA 2006-11-28 15:40:06 EST
This is part of a mass update to close out all stale WTP defects already verified by the reporter but awaiting closure by the assignee.  If you feel this defect was closed inappropriately, please reopen.

Thanks, John Lanuti