Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 113173 - No way to determine an Agent Controller comm problem from LoggingAgent
Summary: No way to determine an Agent Controller comm problem from LoggingAgent
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P1 normal (vote)
Target Milestone: ---   Edit
Assignee: Cindy Jin CLA
QA Contact:
URL:
Whiteboard: closed460
Keywords:
Depends on:
Blocks: 113171
  Show dependency tree
 
Reported: 2005-10-19 18:51 EDT by Dave Smith CLA
Modified: 2016-05-05 10:48 EDT (History)
2 users (show)

See Also:


Attachments
Patch (2.23 KB, patch)
2005-10-20 02:03 EDT, Dave Smith CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Smith CLA 2005-10-19 18:51:40 EDT
The org.eclipse.hyades.logging.core.LoggingAgent class does not throw any 
exceptions or provide a way for the user to determine if the Agent Controller 
is available or accessible.  For example, if a user of LoggingAgent does not 
have the AgentController native DLL libraries in their PATH, the logging agent 
cannot register with the Agent Controller but the user gets no notification of 
this problem.  An example of this is the live log file monitoring scenario 
using standalone GLA configured with a logging agent outputter.  See defect 
https://bugs.eclipse.org/bugs/show_bug.cgi?id=113171.
Comment 1 Dave Smith CLA 2005-10-19 18:56:12 EDT
One solution is to throw an AgentControllerUnavailableException from the 
LoggingAgent constructors.  However that is a breaking API change.

Another solution is to provide an isAgentControllerAvailable() method.
Comment 2 Paul Slauenwhite CLA 2005-10-19 23:27:03 EDT
P2 Highly desirable and planned for this release, but not stop ship 
normal A problem making a function difficult to use but no special work around 
is required
Comment 3 Dave Smith CLA 2005-10-19 23:52:14 EDT
I also suggest calling RemoteComponentSkeleton.initialize() instead of 
initializeFast() in the LoggingAgent constructor to have a better chance of the 
Agent Controller active response being received before LoggingAgent constructor 
returns.  Current behaviour in the 113171 scenario is that initializeFast() 
throws an AgentControllerUnavailableException() even though the agent registers 
successfully with Agent Controller.
Comment 4 Paul Slauenwhite CLA 2005-10-19 23:58:24 EDT
Dave, would LoggingAgent#isLogging() solve your problem (checks if the Logging 
Agent is logging (e.g. Agent Controller is available and the Logging Agent is 
being monitored))?
Comment 5 Dave Smith CLA 2005-10-20 00:14:52 EDT
No, isLogging() will not work.  I want to check if Agent Controller is 
available before the client starts monitoring.  isLogging() will always return 
false at that time.
Comment 6 Dave Smith CLA 2005-10-20 02:03:27 EDT
Created attachment 28498 [details]
Patch

Here is a patch with my suggested fix.
Comment 7 Paul Slauenwhite CLA 2006-04-03 14:56:27 EDT
Cannot contain in TPTP V4.2.0 (i2).
Comment 8 Paul Slauenwhite CLA 2006-06-01 13:39:44 EDT
Cannot contain in TPTP V4.2.0 (i3).
Comment 9 Paul Slauenwhite CLA 2006-08-11 09:52:06 EDT
Re-targeting to 4.3 since no opposition to the request for deferral (http://dev.eclipse.org/mhonarc/lists/tptp-platform-dev/msg00975.html).
Comment 10 Cindy Jin CLA 2006-09-18 10:12:09 EDT
Applied the patch, and submitted to the head of the CVS.
Comment 11 Paul Slauenwhite CLA 2009-06-30 09:47:10 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this originator of this enhancement/defect has an inactive Bugzilla account and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.