Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 112233 - improve interaction for filtered element navigation
Summary: improve interaction for filtered element navigation
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 0.4   Edit
Hardware: Other All
: P2 normal (vote)
Target Milestone: 1.0   Edit
Assignee: Mik Kersten CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 131233 146718 (view as bug list)
Depends on:
Blocks: 135839
  Show dependency tree
 
Reported: 2005-10-11 12:15 EDT by Eugene Kuleshov CLA
Modified: 2006-12-02 12:20 EST (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Kuleshov CLA 2005-10-11 12:15:51 EDT
When mylar filter is on on any view it allows to use Alt-click to temporary expand filtered
nodes. Please add keyboard only alternative for this feature. E.g. using Alt-right keyborad
shortcut on parent node.
Comment 1 Mik Kersten CLA 2005-10-28 19:36:03 EDT
Done, and I'm tempted to say that I like it more than the mouse navigation, but haven't
used it enough yet).  There is no Alt press required, just use the Right Arrow key.  Once
you stop selecting it will filter the uninteresting things.
Comment 2 Eugene Kuleshov CLA 2005-11-04 20:13:53 EST
I've been trying to use this and it behave not as good as one would expect. 
When working with big context I usually collapse some nodes. Now the problem is
that you can't actually differentiate what nodes under collapsed parent already
in the Mylar's context. I had to enable coloring to make it look little better
and still unhappy with the results.

So, I wonder if it is possible to expand to all child nodes on Alt-Right Arrow
key as in original request?

Besides this issue, it looks like Mylar is adding classes to the context just
when I scroll down using keyboard. Then it shrinks the node after randonly
looking timeout. This is quite unexpected. I thought that it should only shring
it back after loosing focus, popup menu call or explicit action using either
mouse or key shortcut (e.g. F3, F5, etc).
Comment 3 Mik Kersten CLA 2005-11-21 11:29:31 EST
That timeout is not random--Eclipse will allow you to navigate via keyboard without firing a post selection event.  But once you stop navigating (for a second or so) and allow the selection to 'rest' on the item, the event is fired.  This also happens in the editor, and Mylar listens to all post selection events.

I differentiate the new nodes that just appeared because they're gray, are you not seeing this?  Would this work better for you if the shortcut was Alt-Right instead of just Right?  
Comment 4 Mik Kersten CLA 2005-11-21 11:30:47 EST
Also note that there is an issue with "Alt" being the modifier, because that doesn't work properly on Linux.  I'll post to the mailing list about this.
Comment 5 Eugene Kuleshov CLA 2005-11-21 11:40:15 EST
(In reply to comment #3)
> That timeout is not random--Eclipse will allow you to navigate via keyboard
> without firing a post selection event.  But once you stop navigating (for a
> second or so) and allow the selection to 'rest' on the item, the event is
> fired.  This also happens in the editor, and Mylar listens to all post
> selection events.
> 
> I differentiate the new nodes that just appeared because they're gray, are you
> not seeing this?  Would this work better for you if the shortcut was Alt-Right
> instead of just Right?  

It would be convenient if Mylar will pause all the monitoring while Alt is pressed...
Comment 6 Mik Kersten CLA 2005-12-16 17:38:19 EST
We should visit this issue before 0.5 goes out, but lowering priority for now.  The trouble with making Mylar pause monitoring when Alt is pressed is that it needs to monitor in order to unfliter what you have selected.  But there is definitely room for improvement in this UI.
Comment 7 Eugene Kuleshov CLA 2006-01-10 14:50:06 EST
How about adding an option that would disable this feature?

Maybe it is a side effect of another bug (e.g. Mylar is collapsing some nodes in Package Explorer when using keyboard shortcut C-A-S-Down to lover interest on some other nodes, but I can't record a reproduceable test case), but when I am expanding collapsed nodes using Right key, Mylar is adding whole bunch of crap into the active context and it is quite annoying.
Comment 8 Mik Kersten CLA 2006-01-31 21:57:21 EST
Eugene voices some additional problems here:
http://dev.eclipse.org/mhonarc/lists/mylar-dev/msg00197.html
Comment 9 Mik Kersten CLA 2006-03-14 13:02:18 EST
This is considerably improved now, with the following issues still outstanding, which may or may not be possible to address:

* mouse: can't unfilter and then select context menu, have to select first, then context menu

* keyboard: down-arrowing causes each element visited to become interesting (not clear if this can be avoided)

Comment 10 Eugene Kuleshov CLA 2006-03-14 16:18:39 EST
(In reply to comment #9)
> * keyboard: down-arrowing causes each element visited to become interesting
> (not clear if this can be avoided)

How about adding them explicitly only when user hit space or maybe enter...
Comment 11 Mik Kersten CLA 2006-03-14 16:54:14 EST
Neither works (Alt+Space is window menu on windows, Alt+Enter is properties in Eclipse).  But I'll try to figure something out.  

Eugene: you'r ethe only one who has requested this, and I assume that you want it for keyboard-only navigation, not a combo of mouse and keyborad, right?
Comment 12 Eugene Kuleshov CLA 2006-03-14 17:00:59 EST
(In reply to comment #11)
> Neither works (Alt+Space is window menu on windows, Alt+Enter is properties in
> Eclipse).  But I'll try to figure something 

...and Alt-Right is used to navigate to next editor.

> Eugene: you'r ethe only one who has requested this, and I assume that you want
> it for keyboard-only navigation, not a combo of mouse and keyborad, right?

There is already combo navigation - Alt-click. So, keyboard only is really missing one. Perhaps it is only me who is trying to stay off the mouse.

BTW, I was doing pair programming anoher day and my partner couldn't navigate anywhere with mouse only when I was holding keyboard. It was quite funny...

Comment 13 Mik Kersten CLA 2006-03-14 19:46:45 EST
I doubt it's just you who wants good keyboard nav.  On a related note, part of my inspiration for coming up with Mylar was that I was tired and getting tendonitis from clicking things what seemed like 10x more than I needed to...
Comment 14 Eugene Kuleshov CLA 2006-03-14 19:53:34 EST
(In reply to comment #13)
> I doubt it's just you who wants good keyboard nav.  On a related note, part of
> my inspiration for coming up with Mylar was that I was tired and getting
> tendonitis from clicking things what seemed like 10x more than I needed to...

That is why I think holding Alt was a bad idea. It is significantly reducing options for keyboard navigation. While it work ok for simple selection it is not solve issues with multiple selection and popup menu even when working with mouse. So, perhaps second Alt-click that been suggested before would be better option to remove temporary filtering. Then you could use Space for marking interest on temporarily unfiltered nodes.
Comment 15 Mik Kersten CLA 2006-04-28 17:11:31 EDT
Sorry Eugene, this has to get punted to 0.5.2.  
Comment 16 Eugene Kuleshov CLA 2006-04-28 17:14:27 EDT
(In reply to comment #15)
> Sorry Eugene, this has to get punted to 0.5.2.  

Dmmit! Inability to call a popup menu on unfiltered node actually became quite annoyong...
Comment 17 Mik Kersten CLA 2006-04-28 17:43:55 EDT
Yup, tell me about it... I end up clicking a file just to keep it around, etc.  
Comment 18 Robert Elves CLA 2006-05-04 15:22:53 EDT
When I use alt-click to reveal the contents of a package, then click on a file (but NOT on a java element within the file), then release the alt key, the file previously clicked is not revealed.

Eclipse 3.2RC2 Mylar 5.1
Comment 19 Mik Kersten CLA 2006-06-28 21:38:50 EDT
*** Bug 131233 has been marked as a duplicate of this bug. ***
Comment 20 Mik Kersten CLA 2006-06-28 23:14:45 EDT
The unfortunately tricky bugs lives on... leaving as P2 in hopes of revisiting for 0.6.1.
Comment 21 Mik Kersten CLA 2006-07-10 11:43:37 EDT
*** Bug 146718 has been marked as a duplicate of this bug. ***
Comment 22 Mik Kersten CLA 2006-09-18 18:28:35 EDT
Eugene's comment from mylar-dev: -- temporary unfiltering is screwed in a number of ways: clicked element does not gain interest and not stick (get filtered out again after releasing alt), can't select two elements from temporarily unfiltered folder, can't use popup menu on those elements... That is leaving keyboard-only navigation alone.
Comment 23 Mik Kersten CLA 2006-09-25 16:56:50 EDT
Deferring again, but this will definitely be revamped for 1.0.
Comment 24 Mik Kersten CLA 2006-11-09 04:32:05 EST
Need to investigate along with changes to common navigator (bug 158692).
Comment 25 Mik Kersten CLA 2006-12-02 12:20:06 EST
I rewired the interaction mechanism to the following, and hopefully it gives us a good compromise:
* Alt can be held down while clicking as before
* Alt+click not required to be held down to unfilter and select, so context menu can be used on not yet interesting elements
* Alt+RightArrow can be used instead of Alt+click, but requires a mouse selection to filter out uninteresting elements
* Multi Alt+clicks are supported, but as soon as a selection is made uninteresting elements will disappear

Please try this out with HEAD or with the upcoming dev build, which should be available shortly.