Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 111414 - Open Type dialog: 'Fully Qualify Duplicates' does not work as expected
Summary: Open Type dialog: 'Fully Qualify Duplicates' does not work as expected
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.2 M3   Edit
Assignee: Dirk Baeumer CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-04 04:50 EDT by Dani Megert CLA
Modified: 2005-11-01 06:14 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2005-10-04 04:50:14 EDT
I20050928-1300

The menu 'Fully Qualify Duplicates' in the Open Type dialog does not affect the
qualification (which is always on for duplicates) but actually appends the
container info.
Comment 1 Martin Aeschlimann CLA 2005-10-05 05:35:01 EDT
I agree that the names are quite confusing.
'Fully qualified' normally means including package. Here it means including
container info.
Suggestion 'Show container for duplicates'

This conflicts with the 'Show container info' which I would call, 'Show status line'

Dirk, why is the first option only for duplicates? Why would you want it there,
but not for the rest? Could the option be removed?

Comment 2 Dirk Baeumer CLA 2005-10-10 16:48:58 EDT
The feature works as follows:

- if Fully Qualify Duplicates is unchecked two types with the same name are   
  qualified until they "name" is unique. 

- if Fully Qualify Duplicates is checked two types with the same name are 
  are alqays qualified with the full container path. 

So the feature works as expected (Dani, if you disagree please provide a test
case). 

However, I can't come up with a better name which is short. 

The option is there to not always qualify the names. This would make reading the
names even harder.
Comment 3 Dani Megert CLA 2005-10-11 05:11:24 EDT
>So the feature works as expected (Dani, if you disagree please provide a test
>case).
I was interpreting 'fully qualify' as the package qualification only and hence
expected that 'Fully Qualify Duplicates' would affect the package qualification
for duplicates which it doesn't.

Now that the function has been explained it boils down to the naming of the menu
entries. Though 'Full Path' is not saying much it's not conflicting with known
terms and it is also used in the Search view.

I also like Martin's suggestion to rename the other item 'Show status line'.
This would make it clear and would even allow to remove the separator, making
the menu smaller and nicer.


Comment 4 Dirk Baeumer CLA 2005-10-11 09:01:26 EDT
Fixed by changing the names and reordering the menu.
Comment 5 Benno Baumgartner CLA 2005-11-01 05:59:08 EST
Verified using I20051031-2000
Dirk can you set it to verified? I can't.
Comment 6 Dirk Baeumer CLA 2005-11-01 06:14:31 EST
Setting to verified.