Bug 111017 - default tab width for MessageConsole changed from 8 to 0 in 3.1
Summary: default tab width for MessageConsole changed from 8 to 0 in 3.1
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.1.2   Edit
Assignee: Kevin Barnes CLA Friend
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-28 21:00 EDT by Tom Houser CLA Friend
Modified: 2006-01-09 15:12 EST (History)
0 users

See Also:


Attachments
Adds fTabWidth initialization to IConsoleConstants.DEFAULT_TAB_SIZE (809 bytes, patch)
2005-12-20 15:20 EST, Gary Barbon CLA Friend
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Houser CLA Friend 2005-09-28 21:00:32 EDT
In Eclipse 3.0, an instance of MessageConsole was automatically initialized 
with a default tab width of 8.

In Eclipse 3.1, an instance of MessageConsole doesn't have its tab width 
initialized at all and thus has a default of zero.

This is API breakage.

Either TextConsole (i.e. the new super-super class of MessageConsole that was 
introduced in 3.1) should initialize its fTabWidth field to 
IConsoleConstants.DEFAULT_TAB_SIZE (i.e. like the 3.0 version of 
MessageConsole initialized its tabWidth field to DEFAULT_TAB_SIZE) or the 
MessageConsole constructors should call setTabWidth() passing 
IConsoleConstants.DEFAULT_TAB_SIZE.
Comment 1 Darin Wright CLA Friend 2005-09-29 08:53:59 EDT
Should also consider for 3.1.2
Comment 2 Gary Barbon CLA Friend 2005-12-20 15:20:53 EST
Created attachment 32038 [details]
Adds fTabWidth  initialization to IConsoleConstants.DEFAULT_TAB_SIZE

TextConsole now initializes its fTabWidth field to IConsoleConstants.DEFAULT_TAB_SIZE, similar to the 3.0 version of 
MessageConsole.
Comment 3 Gary Barbon CLA Friend 2005-12-20 15:21:38 EST
assigning to Darin for review.
Comment 4 Darin Wright CLA Friend 2006-01-04 10:21:49 EST
Applied to 3.2
Comment 5 Darin Wright CLA Friend 2006-01-04 10:30:41 EST
released to 3.1.2
Comment 6 Darin Wright CLA Friend 2006-01-04 10:32:12 EST
Please verify, Kevin.
Comment 7 Kevin Barnes CLA Friend 2006-01-09 15:12:52 EST
verified