Community
Participate
Working Groups
org.eclipse.emf.examples.extlibrary.impl.WriterImpl Method setName in WriterImpl does not send notifcations. Found while testing Live Validation example (org.eclipse.emf.validation.examples). There is a java constraint which requires Writers to not have blank names. Because no notifaction is being sent when the name of a writer is changed, this constraint never comes into play.
Created attachment 27593 [details] Proposed Patch
In addition to what the attached patch does, the notification would also have to be changed by the setFirstName() and setLastName() methods, for the attributes on which the derived "name" attribute depends.
After a discussion with Christian Damus, it was decided that the example constraint which deals with the derived attribute Writer.name will be removed rather than add a notification. Adding a notification to the derived attribute introduces complications which go against the point of providing a simple constraint example. There are already two other constraint examples which demonstrate the same functionality as the Writer.name constraint would have. Therefore removing the Writer.name constraint will not lessen the value of the example.
Created attachment 27826 [details] patch for fix Removed Writer constraints.
Created attachment 27827 [details] patch for fix Previously when the user deleted the Writer's name, the name was being set to " ".
Patches Committed
resolving
Move to verified as per bug 206558.
