Bug 110227 - Possible infinite loop in ProjectSourceContainer
Summary: Possible infinite loop in ProjectSourceContainer
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.1.2   Edit
Assignee: Kevin Barnes CLA Friend
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 109950
  Show dependency tree
 
Reported: 2005-09-21 14:38 EDT by Nobody - feel free to take it CLA Friend
Modified: 2005-12-05 10:10 EST (History)
0 users

See Also:

Attachments
Fix. (2.18 KB, patch)
2005-09-21 14:41 EDT, Nobody - feel free to take it CLA Friend 		no flags Details | Diff
Valid patch. (2.55 KB, patch)
2005-09-22 11:13 EDT, Nobody - feel free to take it CLA Friend 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nobody - feel free to take it CLA Friend 2005-09-21 14:38:18 EDT 
If the project contains cyclic references and the "Find duplicates" option is 
on, "findSourceElements" enters an infinite loop.
Comment 1 Nobody - feel free to take it CLA Friend 2005-09-21 14:41:11 EDT 
Created attachment 27349 [details]
Fix.
Comment 2 Nobody - feel free to take it CLA Friend 2005-09-21 14:44:45 EDT 
The attached patch recursively retrieves all referenced projects instead of 
using the "getReferencedProjects" method of IProject.
Comment 3 Nobody - feel free to take it CLA Friend 2005-09-22 11:13:27 EDT 
Created attachment 27399 [details]
Valid patch.
Comment 4 Nobody - feel free to take it CLA Friend 2005-09-26 11:10:22 EDT 
Is it possible to apply the fix to the 3.0 maintenance branch?
Comment 5 Darin Wright CLA Friend 2005-09-26 11:13:26 EDT 
The final test pass is today... it's likely too late. I don't think this 
classifies as a critical stop ship bug:

http://dev.eclipse.org/viewcvs/index.cgi/%7Echeckout%7E/eclipse-project-
home/plans/3_1/freeze_plan_3_1_1.html
Comment 6 Nobody - feel free to take it CLA Friend 2005-09-26 11:32:44 EDT 
That's a bad news. 
I understand that the simple answer is "Do not use cyclic references". But some 
people use it and the platform doesn't prevent them from doing it.
And the problem is not limited to the case I mentioned. I can fix some in the 
CDT frame, but the all of them.
Comment 7 Darin Wright CLA Friend 2005-09-27 08:59:09 EDT 
Released to HEAD.
Comment 8 Darin Wright CLA Friend 2005-09-27 09:12:15 EDT 
Leaving open to consider for 3.1.2 candidate.
Comment 9 Darin Wright CLA Friend 2005-11-30 14:37:12 EST 
Released to 3.1.2 branch.
Comment 10 Darin Wright CLA Friend 2005-11-30 14:37:31 EST 
Please verify, Kevin.
Comment 11 Kevin Barnes CLA Friend 2005-12-05 10:10:02 EST 
verified