Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 108709 - [Contributions] Every single Java editor is leaked
Summary: [Contributions] Every single Java editor is leaked
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P1 critical (vote)
Target Milestone: 3.2 M3   Edit
Assignee: Douglas Pollock CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-02 12:34 EDT by Dani Megert CLA
Modified: 2005-11-02 11:11 EST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2005-09-02 12:34:41 EDT 
N20050831-0010 (HEAD of org.eclipse.ui.workbench as of now)

The code that was introduced into PopupMenuExtender in order to fix bug 108314
and it leaves RunToLineActionDelegate instances alive which refer to the editor
via fAction.

The new code introduced a life-cycle problem in Platform UI because 2
RunToLineActionDelegate instances get created for each opened editor but
RunToLineActionDelegate.dispose() is never called.
Comment 1 Nick Edgar CLA 2005-09-06 12:51:11 EDT 
Kim is looking into it while Doug is away.
Comment 2 Olivier Thomann CLA 2005-09-06 13:54:14 EDT 
I think this is serious enough to get a rebuild.
Comment 3 Kim Horne CLA 2005-09-06 14:35:52 EDT 
I may roll back Doug's fix for bug 108314 as a temporary solution.
Comment 4 Kim Horne CLA 2005-09-06 14:47:30 EDT 
I rolled back his fixed but there's no need to request a rebuild. It would seem that we haven't submitted 
for this build anyway.
Comment 5 Douglas Pollock CLA 2005-09-30 11:20:34 EDT 
I've fixed Bug 108314 and tried to make sure that this bug wasn't introduced 
again.  I was a subtle behaviour in ViewerActionBuilder that caught me 
unawares last time.
Comment 6 Douglas Pollock CLA 2005-11-02 11:11:29 EST 
Verified in a debugger that one RunToLineActionDelegate creates created when 
an editor is opened, and it gets disposed when the editor closes.  
I20051102-0800.  Linux/GTK+.