Community
Participate
Working Groups
When creating a cvs tag, it would be very helpful if the Tag had a drop down list that shows the last 20 tags used. There are many times when I want to apply the same tag to several folders. Today I have to retype the tag each time and hope that I spell it correctly each time.
I agree. We use content assist in the branch dialog and there is no reason this would work for tagging as well.
Created attachment 108060 [details] Patch I fixed the problem but I'm not sure if it's a proper solution. The tag name is added to the history when the user hits OK button, not when corresponding action is performed. It would be nice if somebody can comment on the fix. Tomasz, what do you think?
I think you are going in the right direction but I have a few comments: * imo we can get away with saving the tag after clicking OK (ignoring whether the operation succeed or not) * If I understood the code correctly DEFAULT_TAG is the last tag used. Isn't it the same tag as TAG_HISTORY[0]? * I don't think we should suggest any tag by default, they should be available in the drop down though * A better name for the argument passed to "rememberTagName" would be "tagName" * The same thing with "filenames" used in the "rememberTagName" method, I would change it to "tagNames" * Would "Vector tagNames = new Vector(Arrays.asList(tagNameHistory));" work for initializing the vector? * Another naming I would change: "_section" to "settingsSection" * "rememberTagName" method doesn't have to be public nor static, does it? * I remember you also mentioned something about adding content assist (ctrl+clicking). Are you going to provide a patch for it as well? One thing we should be aware of here, is that mixing tags from history with other tags for a selected resource might be confusing.
Created attachment 108522 [details] Patch Tomasz, I agree with all your suggestions and I've changed the patch according to them. Regarding the last point I think we can leave the dialog without implementing the content assist. What do you think about it?
(In reply to comment #4) > Regarding the last point I think we can leave the dialog without implementing > the content assist. What do you think about it? I'm fine with it. The drop down list you made should be enough... at least for now. btw, I can see you reduced the history size from 20 to 10 items. I thought about the same thing, you're reading my mind :) This would be my last comment. I did some minor, cosmetic changes but other than that it looks good. Releasing...
Second patch applied to HEAD.
