Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 108502 - action filters for variables and expressions shold be combined
Summary: action filters for variables and expressions shold be combined
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 M4   Edit
Assignee: Darin Wright CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-31 15:10 EDT by Darin Wright CLA
Modified: 2005-11-24 10:17 EST (History)
0 users

See Also:

Attachments
patch (17.00 KB, patch)
2005-11-16 15:23 EST, Michael Rennie CLA 		no flags Details | Diff
patch (17.00 KB, patch)
2005-11-16 15:32 EST, Michael Rennie CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Wright CLA 2005-08-31 15:10:25 EDT 
3.1

The two classes JavaVariableActionFilter and JavaInspectExpressionActionFilter 
do almost identical things and should be combined to avoid duplicated code.
Comment 1 Michael Rennie CLA 2005-11-16 15:23:04 EST 
Created attachment 30093 [details]
patch

removed the duplicate classes and created one smaller unified class.

please verify Darin.
Comment 2 Darin Wright CLA 2005-11-16 15:24:31 EST 
Needs verification
Comment 3 Michael Rennie CLA 2005-11-16 15:32:48 EST 
Created attachment 30094 [details]
patch

removed the duplicate classes and created one smaller unified class.

please verify Darin.
Comment 4 Darin Wright CLA 2005-11-24 10:17:29 EST 
Applied patch.
Comment 5 Darin Wright CLA 2005-11-24 10:17:39 EST 
Verified.