Community
Participate
Eclipse IDE
3.1. The type history consistency check is done every time the dialog opens. However this check is only needed when types have been removed from the system. So the history could listen on delta changes an only perform the check if necessary.
Created attachment 26526 [details] The patch
Dani, Markus can you please review the patch.
The code got released into Head beginning of August and is shipped with M1. No complains so far. So if you are happy with the patch I would like to backport it to 3.1.1.
One additional note: the code is basically the old all types cache flush listener code.
The patch is fine, +1 for 3.1.1.
Reviewed the patch. For me it is OK to release. I found the following minor issues: - with the patch there's now a small timeframe where the dialog's data can be inconsistent if the user removes or changes a type quickly in the editor and opens the dialog immediately afterwards. I don't see this as a show stopper - Javadoc and field have typo: fHistroy [this has not been introduced by the patch] - the introduced delta listener has commented method - IProgressMonitor.done() should be inside a finally block
Dani, thanks for the review. Here my comments: 1.) Agree that there is a small window where this can happen. However if it occurrs the dialog still behaves OK. Selecting the element and trying to reopnen it simply gives a message dialog. Fixing this will require reconcling the CU which might introduce dead locks. 2.) will fix this in HEAD 3.) removed 4.0 will fix this in HEAD since the code already existed like this in 3.1.0.
Verified using M20050831-1200 + ZRH plugin export
