Bug 107706 - Infer type arguments does not add type arguments to fully qualified types
Summary: Infer type arguments does not add type arguments to fully qualified types
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1.1   Edit
Assignee: Markus Keller CLA Friend
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-23 06:11 EDT by Markus Keller CLA Friend
Modified: 2005-09-02 09:48 EDT (History)
2 users (show)

See Also:


Attachments
Fix (1.49 KB, patch)
2005-08-23 06:17 EDT, Markus Keller CLA Friend
no flags Details | Diff
Tests (1.93 KB, patch)
2005-08-23 06:19 EDT, Markus Keller CLA Friend
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA Friend 2005-08-23 06:11:11 EDT
public class A {
	A() {
		java.util.List list= new java.util.ArrayList();
		list.add(1);
	}
}
Comment 1 Markus Keller CLA Friend 2005-08-23 06:17:27 EDT
Created attachment 26370 [details]
Fix
Comment 2 Markus Keller CLA Friend 2005-08-23 06:19:11 EDT
Created attachment 26371 [details]
Tests
Comment 3 Markus Keller CLA Friend 2005-08-23 06:25:41 EDT
Dirk, could you please approve for 3.1.1?

The current code just skips types that are not simple names. The change only
affects the rewriting phase and is low risk.
Comment 4 Dirk Baeumer CLA Friend 2005-08-23 08:17:57 EDT
Approved for 3.1.1.
Comment 5 Markus Keller CLA Friend 2005-08-23 08:25:39 EDT
Tobias, can you please review the patch as well?
Comment 6 Tobias Widmer CLA Friend 2005-08-23 08:47:49 EDT
Approved for 3.1.1
Comment 7 Markus Keller CLA Friend 2005-08-23 09:23:36 EDT
Released patches to 3.1.1 and HEAD.
Comment 8 Dirk Baeumer CLA Friend 2005-09-02 09:42:55 EDT
Start verifing...
Comment 9 Dirk Baeumer CLA Friend 2005-09-02 09:48:43 EDT
Verified on M20050831-1200.

Verified that fully qualified names and simple names and combinations of them
still work.