Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 107521 - Enable custom event format handling/loading
Summary: Enable custom event format handling/loading
Status: CLOSED WONTFIX
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P2 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Harm Sluiman CLA
QA Contact:
URL:
Whiteboard: housecleaned460 closed460
Keywords:
Depends on: 130942
Blocks:
  Show dependency tree
 
Reported: 2005-08-20 14:46 EDT by Marius Slavescu CLA
Modified: 2016-05-05 10:57 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marius Slavescu CLA 2005-08-20 14:46:12 EDT
This defect would be used to enable custom event  formats (including binary
representation).
Most of the plumbing is already available some hooks and extended loader support
 needs to be added.

The producer of the custom event format will need to also provide a handler
(XMLFragmentHandler) for that format that will be used in the XMLLoader and the
plumbing to trigger that handler (explained bellow). We will try to provide a
binary format for TPTP profiler traces.

Basically the custom format would be translated directly in IXMLLoader
(IExtendedLoader) SAX related events (not exactly SAX but very similar) by a
custom XMLFragmentHandler which knows how to handle binary data instead of XML
text data, the only thing missing is the code that triggers the right
XMLFragmentHandler when the format is not XML based. This can be done easily by
overriding the XMLLoader.makeScanner() method.

The custom (binary) XMLFragmentHandler would need to send SAX related events as
it does the binary events processing.

An immediate improvement would be to add a set of pair methods in
XMLFragmentLoader (I would add a XMLExtendedFragmentLoader interface and update
all TPTP know loaders, this will not be a breaking change) which would accept
attributeIds (currently I use internally the attribute name hash code, although
we could use a different mapping, which can be provided by the agent) and
elementIds instead of the String representation, that would avoid the hash code
computation.

The XMLExtendedFragmentLoader would need to support a mode where a bean with the
event data would be passed instead of individual attributes/elements so I will
add an addYourselfInContext with a DOM like object as argument, the bean would
contain all the data captured in that event, this mode should improve the
performance when the data can be quickly converted into a DOM so we don't need
to parse it in the loaders.

All these changes would enhance and not break the existing infrastructure.
Comment 1 Marius Slavescu CLA 2005-10-05 12:14:56 EDT
Moved to 4.1 i3, not used in current implementation.
Comment 2 Marius Slavescu CLA 2005-10-12 11:06:30 EDT
FIx in CVS.
Comment 3 Marius Slavescu CLA 2005-10-12 11:06:55 EDT
sorry closed the wrong bug
Comment 4 Marius Slavescu CLA 2005-10-27 12:43:54 EDT
Decrease severity, not critical for 4.1.
Comment 5 Marius Slavescu CLA 2005-10-27 12:46:14 EDT
Retargeted to 4.2
Comment 6 Marius Slavescu CLA 2006-03-31 09:12:39 EST
Need to clean up the spec before implementing this.
Comment 7 Marius Slavescu CLA 2006-05-15 10:41:15 EDT
Move to 4.2 i4, this being provisional code, currently is not used.
Comment 8 Marius Slavescu CLA 2006-05-15 23:49:34 EDT
Marked as P2 for further investigation and approval.
Comment 9 Marius Slavescu CLA 2006-06-02 09:45:32 EDT
Moving to 4.3 as it cannot be contained in 4.2.
Comment 10 Valentina Popescu CLA 2006-07-10 23:27:38 EDT
Ruth, this is a model defect
Comment 11 Harm Sluiman CLA 2008-01-02 16:13:48 EST
This is an important enhancement for TPTP but currently not in scope. It may be part of the soon to be discussed binary event format improvement request.
Comment 12 Paul Slauenwhite CLA 2009-06-30 06:33:09 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As such, TPTP is not delivering enhancements. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement is resolved as WONTFIX. For this enhancement to be considered, please re-open with an attached patch including the Description Document (see http://www.eclipse.org/tptp/home/documents/process/development/description_documents.html), code (see http://www.eclipse.org/tptp/home/documents/resources/TPTPDevGuide.htm), and test cases (see http://www.eclipse.org/tptp/home/documents/process/TPTP_Testing_Strategy.html).
Comment 13 Paul Slauenwhite CLA 2009-06-30 06:36:31 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As such, TPTP is not delivering enhancements. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement is resolved as WONTFIX. For this enhancement to be considered, please re-open with an attached patch including the Description Document (see http://www.eclipse.org/tptp/home/documents/process/development/description_documents.html), code (see http://www.eclipse.org/tptp/home/documents/resources/TPTPDevGuide.htm), and test cases (see http://www.eclipse.org/tptp/home/documents/process/TPTP_Testing_Strategy.html).
Comment 14 Paul Slauenwhite CLA 2009-06-30 09:40:49 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this originator of this enhancement/defect has an inactive Bugzilla account and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.