Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 107372 - Mechanism required to generate source features with jar'd plug-ins
Summary: Mechanism required to generate source features with jar'd plug-ins
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 3.2   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.2 M5   Edit
Assignee: Andrew Niefer CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 107603 109792
  Show dependency tree
 
Reported: 2005-08-18 16:16 EDT by Sonia Dimitrov CLA
Modified: 2006-02-08 09:21 EST (History)
3 users (show)

See Also:

Attachments
patch (3.15 KB, patch)
2006-01-16 14:29 EST, Andrew Niefer CLA 		no flags Details | Diff
patch for fetch (1.11 KB, patch)
2006-02-03 13:06 EST, Andrew Niefer CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sonia Dimitrov CLA 2005-08-18 16:16:28 EDT 
I would like to jar the org.eclipse.platform.doc isv plug-in which is part of
the org.eclipse.platform.source feature.  I believe the only way for me to do
this currently is to keep a hard-coded feature.xml in the sourceTemplateFeature
in the org.eclipse.platform-feature with the attribute unpack="false".

This is a request for a mechanism that triggers the addition of unpack="false"
for plugins listed in generated source feature.xml via the generate.feature
property.

ie. maybe something like:

generate.feature@org.eclipse.platform.source=org.eclipse.platform,
plugin@org.eclipse.platform.doc.isv;unpack="false"
Comment 1 Pratik Shah CLA 2005-09-16 15:44:14 EDT 
Any progress on this front?
Comment 2 Jeff McAffer CLA 2005-09-18 22:19:07 EDT 
This sounds like a cool idea.  Perhaps Andrew could look at this...

BTW, just to be sure, Help is happy with content in JAR'd plugins?  Does it 
force the content to be extracted before it can show up on the Help site?  Is 
there anything else about the doc plugin that needs to be changed if it is 
jard? (e.g., extension markup, ...)
Comment 3 Konrad Kolosowski CLA 2005-09-19 10:09:23 EDT 
Help is happy with doc plug-ins running from jars.  If plug-in is to be run 
from jar, the doc.zip generation build step should be skipped.  HTML and 
associated files should be in plug-in jar, not zip in a jar.

The docs and resources are served by help from jars except the prebuilt 
indexes.  They are extracted  before being merged.

No change to the doc plug-in markup is needed.
Comment 4 Jeff McAffer CLA 2005-09-19 10:36:13 EDT 
Sounds good.  Somehow the build scripts for the source feature has to pass 
along that the doc.zip step should be skipped for hte doc plugins that have 
unpack=false
Comment 5 Andrew Niefer CLA 2006-01-16 14:29:47 EST 
Created attachment 33093 [details]
patch

Patch adds handling for ;unpack="false" as in Sonia's example above
Comment 6 Pascal Rapicault CLA 2006-01-16 15:23:26 EST 
Patch released in HEAD.
Comment 7 Sonia Dimitrov CLA 2006-02-01 11:29:08 EST 
I tested this in a special patch sent by Pascal and the platform.doc.isv plug-in is not being fetched, thus the build fails.  Is this something I need to do in customTargets.xml?
Comment 8 Sonia Dimitrov CLA 2006-02-02 16:34:55 EST 
Reopening on account of fetch problem.  Please close if these plug-ins need to be explicitly fetched.
Comment 9 Andrew Niefer CLA 2006-02-03 13:06:24 EST 
Created attachment 34100 [details]
patch for fetch

Problem stems from fetch looking in the map files for "plugin@org.eclipse.platform.doc.isv;unpack="false"" when it should be looking for 
"plugin@org.eclipse.platform.doc.isv"

fix is simple
Comment 10 Pascal Rapicault CLA 2006-02-08 09:21:43 EST 
Second patch applied.