107107 – Location.setURL does not provide sufficient information when failing to set the workspace location

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 107107 - Location.setURL does not provide sufficient information when failing to set the workspace location

Summary: Location.setURL does not provide sufficient information when failing to set t...

Status:	RESOLVED DUPLICATE of bug 67220

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	Runtime (show other bugs)
Version:	3.1
Hardware:	PC Linux

Importance:	P3 enhancement (vote)
Target Milestone:	---
Assignee:	platform-runtime-inbox
QA Contact:

URL:
Whiteboard:
Keywords:

Duplicates (2):	107109 110582 (view as bug list)
Depends on:
Blocks:

Reported:	2005-08-16 07:57 EDT by Oleg Krasilnikov
Modified:	2007-03-30 09:28 EDT (History)
CC List:	2 users (show)

See Also:

Attachments
Problem fix patch (3.74 KB, patch) 2005-08-18 01:01 EDT, Oleg Krasilnikov	no flags	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Oleg Krasilnikov

2005-08-16 07:57:01 EDT

When workspace location is set to not-existing directory, 
and Eclipse cannot create it (no write permissions for
upper directory, etc), the following message is displayed: 
"Workspace is already in use". It can confuse user. 
Text like "Cannot create workspace: /a/b/c/d" may be more useful.

Comment 1 Oleg Krasilnikov

2005-08-16 08:05:28 EDT

Problem can be fixed by modification of 2 files:
BasicLocation.java - setURL() and lock() methods are affected
IDEApplication.java - checkInstanceLocation() is affected.

Patch will be proposed ASAP.

Comment 2 Rafael Chaves

2005-08-16 10:16:57 EDT

*** Bug 107109 has been marked as a duplicate of this bug. ***

Comment 3 Oleg Krasilnikov

2005-08-18 01:01:32 EDT

Created attachment 26220 [details]
Problem fix patch

Comment 4 Oleg Krasilnikov

2005-08-18 01:08:25 EDT

Additional check is performed after workspace lock fails.
It can occur either due to another lock, or because of
workspace directory absence. The 2nd case is now reported.

Comment 5 DJ Houghton

2005-08-18 07:05:17 EDT

You mention that there are code changes in BasicLocation but that code isn't
included in the patch.

We only close and mark bugs as FIXED when the code has been released to the
repository.

Re-opening to move to UI since the patch contains only UI code.

They can close it if indeed the code has been released and the problem fixed in
the builds.

Comment 6 Oleg Krasilnikov

2005-08-18 07:30:47 EDT

Modification in BasicLocation.java was not required indeed.
Comment from 16.08 was preliminary estimation only.

What about wrong state I've put bug, it's my fault. Sorry.

Comment 7 Pascal Rapicault

2006-03-22 18:37:04 EST

*** Bug 110582 has been marked as a duplicate of this bug. ***

Comment 8 Michael Van Meekeren

2006-04-20 16:06:00 EDT

so is there a new patch coming Oleg?

Comment 9 Oleg Krasilnikov

2006-04-21 06:40:38 EDT

Proposed patch seems to be actual.

Comment 10 Michael Van Meekeren

2006-04-21 11:22:18 EDT

Oleg, thanks for the patch and hard work, I have a few concerns: 

- calling File.mkdirs() can create folders so doing this in the UI as a check is not a good idea
- the Location interface in Core/Runtime should provide more information about what went wrong and the UI will expose that information to the user as appropriate as we can not be sure that we are dealing with a file based location similar to Basiclocation


So after discussing with DJ, I'm updating the message slightly for 3.2 and moving this bug to Runtime to address changes in BasicLocation in the future

Comment 11 Thomas Watson

2006-04-21 11:46:14 EDT

see bug 131891, this is likely a dup of that.

Comment 12 DJ Houghton

2007-03-30 09:28:27 EDT


*** This bug has been marked as a duplicate of bug 67220 ***