Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 106959 - [Contributions] missing mnemonics in the main menu bar
Summary: [Contributions] missing mnemonics in the main menu bar
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 3.2 M2   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 140861
  Show dependency tree
 
Reported: 2005-08-14 10:19 EDT by Michael Schneider CLA
Modified: 2006-06-06 14:16 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Schneider CLA 2005-08-14 10:19:17 EDT
When I press ALT to access the main menu bar, 
some mnemonics are missing:

  * 'R' for the "Run" menu
  * 'W' for the "Window" menu

There are also missing mnemonics within some of the menus:

  * all Resources in the File>New submenu
  * File > Convert Line Delimiters To
  * Navigate > Goto > Type... 
  * Navigate > Goto > Package...
  * Navigate > Show In  and all its subentries
  * Search > Read Access
  * Search > Write Access
  * Project > Build Working Set
  * all perspectives within Window > Open Perspective
  * all views within Window > Show View
  * Window > Navigation > Maximize active View or Editor
  * Window > Navigation > Minimize active View or Editor
Comment 1 Martin Aeschlimann CLA 2005-08-15 05:24:27 EDT
Which build is this? In 3.1.1 some of the actions you name seem to have a mnemonic,
e.g. Run, Debug, File > Convert Line Delimiters To, Search > Read Access/Write
Access

I can see the missing menmonics for the File>New submenu, Window > Open
Perspective, Window > Show View, Maximize/Minimize active View or Editor

For the lists of subitems the (1, 2, 3...) style used in the Run/Debug menu
could be used.

  * Navigate > Goto > Type... 
  * Navigate > Goto > Package...
Has a mnemonic set on the action but it seems to get lost for the menu.

Moving to platform.ui

Comment 2 Michael Schneider CLA 2005-08-15 18:09:47 EDT
Answer to question about build:

  Version: 3.1.0
  Build id: I20050627-1435
Comment 3 Douglas Pollock CLA 2005-08-23 10:37:55 EDT
It is likely that you are using the Emacs key configuration.  If so, "Alt+R"  
is "Find/Replace", "Alt+W" is "Copy" and "Alt+V" is line up.  As such, they 
are disabled as mnemonics.  
  
This accounts for the following:  
+ 'R' for the "Run" menu 
+ 'W' for the "Window" menu 
+ File > Convert Line Delimiters To 
+ Navigate > Show In 
+ Search > Read Access 
+ Search > Write Access 
+ Project > Build Working Set 
 
The following are actually missing mnemonics: 
+ all Resources in the File>New submenu 
+ Navigate > Goto > Type...  
+ Navigate > Goto > Package... 
+ Navigate > Show In subentries 
+ all perspectives within Window > Open Perspective 
+ all views within Window > Show View 
+ Window > Navigation > Maximize active View or Editor 
+ Window > Navigation > Minimize active View or Editor 
 
The Eclipse User Interface Guidelines don't appear to specify the mnemonics 
are required, but they are helpful. 
Comment 4 Michael Schneider CLA 2005-08-23 16:53:35 EDT
> It is likely that you are using the Emacs key configuration.

Yes, I am using Emacs mode.

> The Eclipse User Interface Guidelines don't appear to specify the mnemonics 
are required, but they are helpful.

[Offtopic] Perhaps some discussion about this point in the guidelines would be
useful, because many programmers (like me and others I know) like to control
their programming environment completely by keyboard, because switching between
mouse and keyboard is rather inefficent (or at least feels inefficent). For such
people mnemonics are more than just helpful. 
Comment 5 Douglas Pollock CLA 2005-08-24 14:42:15 EDT
I've fixed everything except for: 
+ Navigate > Goto > Type...  
+ Navigate > Goto > Package... 
 
I've opened Bug 107905 to track those two missing mnemonics, and I'll close 
this bug as fixed. 
Comment 6 Michael Van Meekeren CLA 2005-09-20 14:25:52 EDT
While testing this on Motif - I20050920 I found the following, generally cases
where the mnemonic is picked as the first letter: 

File > New (submenu)
   - duplicate mnemonic between Folder and File (on motif hitting "f" twice does
not cycle through)

Window > Open Perspective
   - duplicate mnemonic with Java and Java Browsing (i.e. "J")

Window > Show view 
   - duplicate for Problems view and Package Explorer for example
Comment 7 Douglas Pollock CLA 2005-09-22 09:58:59 EDT
MVM: This is intentional.  Duplicate mnemonics are not bad, and are actually 
generally a good idea when the list of names being displayed is not static. 
Comment 8 Douglas Pollock CLA 2005-09-22 10:09:23 EDT
Verified in I20050921-2000. 
Comment 9 Tod Creasey CLA 2006-06-06 14:09:41 EDT
Reopening. This is causing Bug 140861.

The fix for this adds a & to the beginning of the label in the Show View Menu which is incorrect in Asian locales.

The assigning of mnemonics programatically should generally be avoided. We should explicitly have an entry for the menu in the schema for views and wizards. Until then we should back out of this.
Comment 10 Tod Creasey CLA 2006-06-06 14:16:48 EDT
I am going to mark this as WONTFIX. A more robust solution is described in Bug 145593.

We will be rolling back these changes in order to correct Bug 140861