Community
Participate
Working Groups
Trying to browse the file system using a file chooser dialog was not possible. The file chooser dialog doesn't refresh when I click on the [+]. I am using I20050808-0800 with a patch for bug 106361.
Does not happen on Windows XP with the manifest. However, happens on Windows XP without the manifest (and might also happen on Windows 2000, 98 and NT). As part of the fix for Bug 60659, asyncExecs are disabled while the directory dialog is open. Bug 60659 is a GP. It appears that InputMonitor, which was added for 3.2, is relying on the asyncExecs to be run while the dialog is open and this is not happening. If I comment out <code>InputMonitor.init()</code> on line 2099 of WorkbenchPage, the directory dialog performs nicely. For 3.2 M1, can we disable InputMonitor and then investigate what is going on here?
The InputMonitor was added by Stefan last week to implement focus-stealing prevention. This was Bug 85608. We can roll back the entire patch to get us through 3.2 M1. Does this only affect DirectoryDialog on Windows XP?
Veronika thinks this needs to be rolled back but I'll need some context from Doug and Veronika before I do it.
Created attachment 25891 [details] Rollback patch Here is a rollback patch. I would like Doug to verify this before I commit though.
If you wish to minimize the rollback, I think you can just comment out the mouse up and mouse down events from the list of filtered events in InputMonitor. I believe the slow down will appear on all Windows (XP, 2K, NT, etc) except for Windows XP with a manifest.
The rollback patch doesn't cover all of the stuff from Bug 85608. I'll make a revised rollback patch. dpollock@node2:/home/eclipse> grep -ri '85608' org.eclipse.ui.ide org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/IDEWorkbenchPreferencePage.java,v:@Bug 85608: Preference to prevent parts from stealing focus dpollock@node2:/home/eclipse> grep -ri '85608' org.eclipse.ui.workbench org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/WorkbenchPreferencePage.java,v:@Bug 85608: Preference to prevent parts from stealing focus org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/InputMonitor.java,v:@Bug 85608: Preference to prevent parts from stealing focus org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/messages.properties,v:@Bug 85608: Preference to prevent parts from stealing focus org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchMessages.java,v:@Bug 85608: Preference to prevent parts from stealing focus org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java,v:@Bug 85608: Preference to prevent parts from stealing focus org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/IPreferenceConstants.java,v:@Bug 85608: Preference to prevent parts from stealing focus
Created attachment 25895 [details] Patch to "org.eclipse.ui.ide"
Created attachment 25896 [details] Patch to "org.eclipse.ui.workbench"
STEPS TO REPRODUCE: 1.) Open the File > Import/Export... dialog 2.) Select "File system" and click "Next" 3.) Click "Browse" 4.) Try to expand one of the items using a mouse click on the "+" symbol. A busy cursor will appear, but the tree will never expand. The dialog can still be cancelled, and a timeout will eventually dismiss the busy cursor. Confirmed that this affects both Windows 2000 and some Windows XP boxes.
Patches have been applied to HEAD.
Should have marked as FIXED....
I also observed this on I20050808-2000. The folders eventually do expand, but it takes a LOOOONG time. I'm running Win XP Pro Version 2002 Service Pack #1
Verified by Veronika in 20050810-0100
Susan and Olivier, Go get javaw.exe.manifest and copy it into your jre bin directory so you can run SWT (therefore eclipse) with the latest version of Windows controls. http://dev.eclipse.org/viewcvs/index.cgi/~checkout~/platform-swt- home/javaw.exe.manifest
is this patch also applicable for eclipse 3.1?
This wasn't an issue in 3.1.
> This wasn't an issue in 3.1. Does this mean, this bug is not related to bug 88958?
Correct - our issue was due to the (now deleted) InputMonitor class.
