106367 – [Progress] Missing image for jobs in the progress view

Bug 106367 - [Progress] Missing image for jobs in the progress view

Summary: [Progress] Missing image for jobs in the progress view

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	Search (show other bugs)
Version:	3.2
Hardware:	PC Windows XP

Importance:	P2 normal (vote)
Target Milestone:	3.1.1
Assignee:	Platform-Search-Inbox
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2005-08-08 11:45 EDT by Tobias Widmer
Modified:	2005-09-02 08:54 EDT (History)
CC List:	2 users (show)

See Also:

Attachments
patch (1001 bytes, patch) 2005-08-10 05:03 EDT, Martin Aeschlimann	no flags	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tobias Widmer

2005-08-08 11:45:51 EDT

I20050808-0800

The progress view shows the little red square in the upper-left corner of the 
job icon. Apparently, the icon cannot be found anymore

Comment 1 Tod Creasey

2005-08-08 13:35:16 EDT

I am not sure what image you are talking about. Are saying that it looks like
the yellow dot job icon is decorated with something that is missing?

I checked on startup and we are finding all of the images

Comment 2 Tobias Widmer

2005-08-09 04:44:33 EDT

I checked again and can reproduce it on I20050808-2000, performing either a 
Java search or a File search. So it might also be a search-specific problem.

Comment 3 Tod Creasey

2005-08-09 16:22:18 EDT

This is a bug in the search 

org\eclipse\search\internal\ui\SearchPluginImages.java

line 41 reads
	public static final String T_VIEW= "view16/"; //$NON-NLS-1$

it should be

	public static final String T_VIEW= "eview16/"; //$NON-NLS-1$

Comment 4 Dani Megert

2005-08-09 17:06:28 EDT

Note that this bug got also introduced into 3.1.

Comment 5 Martin Aeschlimann

2005-08-10 05:03:39 EDT

Created attachment 25953 [details]
patch

Comment 6 Martin Aeschlimann

2005-08-10 05:05:13 EDT

Bug got introduced by the image-nls fix for 3.1.1. Dani and Tobias, can you
please review the patch?

Comment 7 Tobias Widmer

2005-08-10 05:08:23 EDT

Patch looks good to me

Comment 8 Dani Megert

2005-08-10 06:30:17 EDT

Verified the patch and verified that the icon appears in the Progress view.

Minor suggestion: rename the field to T_EVIEW as we did in JavaPluginImages.

Comment 9 Martin Aeschlimann

2005-08-10 08:01:51 EDT

fixed in 3.1.1 stream and 3.2

Comment 10 Dani Megert

2005-09-02 08:21:02 EDT

Starting verification...

Comment 11 Dani Megert

2005-09-02 08:54:32 EDT

Verified using M20050831-1200