Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 105937 - [Plan Item] Cross resource containment
Summary: [Plan Item] Cross resource containment
Status: VERIFIED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: Core (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows XP
: P1 enhancement (vote)
Target Milestone: Past   Edit
Assignee: Marcelo Paternostro CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 80312
  Show dependency tree
 
Reported: 2005-08-03 11:52 EDT by Elena Litani CLA
Modified: 2008-01-28 16:47 EST (History)
4 users (show)

See Also:


Attachments
A zip of patches and an example (66.52 KB, application/zip)
2005-10-11 14:57 EDT, Ed Merks CLA
no flags Details
Proper example for this patch (89.60 KB, application/x-zip-compressed)
2005-10-12 06:33 EDT, Ed Merks CLA
no flags Details
Updated patches relative to latest CVS source (81.62 KB, application/x-zip-compressed)
2005-10-17 09:12 EDT, Ed Merks CLA
no flags Details
A replacement patch for the org.eclipse.emf.ecore.xmi plugin (6.85 KB, application/octet-stream)
2005-10-22 12:30 EDT, Ed Merks CLA
no flags Details
An Eclipse 3.2 multipatch for all the changes relative to the current 2.2 HEAD (276.41 KB, patch)
2005-11-07 14:46 EST, Ed Merks CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Elena Litani CLA 2005-08-03 11:52:00 EDT
Investigate containment crossing resources boundaries
Comment 1 Ed Merks CLA 2005-10-11 14:57:25 EDT
Created attachment 28134 [details]
A zip of patches and an example 

The zip file contains patches for org.eclipse.emf.ecore,
org.eclipse.emf.ecore.xmi, and org.eclipse.emf.codegen.ecore.
It also contains an example showing how the new support works.	Note that the
example contains a Rose model, but the .ecore has been changed since it was
generated from the Rose model.

The basic idea behind the design is to handle resource containment differently
for containment references for which resolveProxies is true.  Currently all
generated EReferences will have this set to false, regardless of what's in the
.ecore.  With the new design, the settings will be respected in the generated
code.  The new design should be a no-op for existing generated models.

The idea is that when adding to a containment, if the containment can resovle
proxies, the newly contained object will NOT be removed from its directly
containing resource.
Comment 2 Ed Merks CLA 2005-10-12 06:33:52 EDT
Created attachment 28170 [details]
Proper example for this patch

I zipped the wrong example plugins in the previous attachment.	This is the
right example.
Comment 3 Ed Merks CLA 2005-10-17 09:12:21 EDT
Created attachment 28331 [details]
Updated patches relative to latest CVS source

Fixing https://bugs.eclipse.org/bugs/show_bug.cgi?id=112330 required source
changes that affected this patch set, so I've created a fresh patch set.
Comment 4 Ed Merks CLA 2005-10-22 12:30:52 EDT
Created attachment 28653 [details]
A replacement patch for the org.eclipse.emf.ecore.xmi plugin

This patch fixes the problem with container reference serialization reported in
the newsgroup.
Comment 5 Ed Merks CLA 2005-11-07 14:46:48 EST
Created attachment 29471 [details]
An Eclipse 3.2 multipatch for all the changes relative to the current 2.2 HEAD

This is just an updated patch to make it easy to apply the changes against
HEAD.
Comment 6 Ed Merks CLA 2005-11-19 08:25:13 EST
The changes are committed to CVS.  And all the tests pass!
Comment 7 Nick Boldt CLA 2005-11-24 11:31:16 EST
Fixed in 2.2.0 I200511240817.
Comment 8 Nick Boldt CLA 2008-01-28 16:47:31 EST
Move to verified as per bug 206558.