Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 105894 - [CellEditors] TableEditorImpl uses wrong object in call to ICellModifier.modify
Summary: [CellEditors] TableEditorImpl uses wrong object in call to ICellModifier.modify
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows 2000
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-03 05:08 EDT by Vlad Dumitrescu CLA
Modified: 2021-09-04 15:29 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vlad Dumitrescu CLA 2005-08-03 05:08:05 EDT
I didn't found any report on this, but I think it is a bug.

TableEditorImpl calls ICellModifier (at line 314) like this
    cellModifier.modify(tableItem, property, cellEditor.getValue());

but I think it should be
    cellModifier.modify(tableItem.getData(), property, cellEditor.getValue());
                                 ^^^^^^^^^^
so that it's symmetrical with ICellModifier.getValue

regards,
Vlad
Comment 1 Keith McQueen CLA 2006-03-02 11:43:30 EST
It is ridiculous that both the ICellModifier#getValue and ICellModifier#canModify methods both use the user's domain object while the ICellModifier#modify method uses the eclipse TableItem object.
Comment 2 Eric Moffatt CLA 2006-03-07 09:20:54 EST
I agree, unfortunately published API (even when broken) is cast in stone once published since we have no way of knowing who we'd break if we changed the semantics of the call.

That's likely why the javadoc gives the workaround...

Things like this usually get picked up in a 'sweep' that results in new API while honoring the old API (and we recognize that the CellEditor / PropertySheetPage etc desperately need one...;-).
Comment 3 Eclipse Webmaster CLA 2019-09-06 16:05:49 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 4 Eclipse Genie CLA 2021-09-04 15:29:25 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.