105874 – [DnD] [RCP] Unable to perform DROP_LINK operations in the editor area

Bug 105874 - [DnD] [RCP] Unable to perform DROP_LINK operations in the editor area

Summary: [DnD] [RCP] Unable to perform DROP_LINK operations in the editor area

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	3.1
Hardware:	PC Windows XP

Importance:	P3 major (vote)
Target Milestone:	3.1.2
Assignee:	Eric Moffatt
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2005-08-02 19:35 EDT by Richard Gould
Modified:	2006-01-10 10:47 EST (History)
CC List:	3 users (show)

See Also:

Attachments
Add "DROP_LINK" to the list of valid operations for the EditorSashContainer (854 bytes, patch) 2005-10-05 15:09 EDT, Eric Moffatt	no flags	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Richard Gould

2005-08-02 19:35:27 EDT

I am trying to support dropping of links from Internet Explorer to the blank
editor area (WorkbenchWindow?) of our RCP application.

As far as I can tell from examining the Eclipse source code, IE wants this
operation to be a DROP_LINK.

It would seem that the DropTarget object being instantiated automatically by the
RCP is being initialized with the style 'DND.DROP_DEFAULT | DND.DROP_COPY', thus
all DROP_LINK operations are disallowed. This instantiation occurs in
org.eclipse.ui.internal.EditorSashContainer and seems to be preventing us from
supporting dropping of links from IE.

Would it be possible to get support for DROP_LINK?

Comment 1 Richard Gould

2005-08-03 19:39:49 EDT

Oops - just noticed I had linux set. (I submitted the bug using a linux machine :)

Comment 2 Eric Moffatt

2005-10-05 15:09:42 EDT

Created attachment 27891 [details]
 Add "DROP_LINK" to the list of valid operations for the EditorSashContainer

Comment 3 Michael Van Meekeren

2005-10-11 15:14:12 EDT

richard, have you tried this patch.  I'm wondering if this works for you, before
we put it in?

Comment 4 Michael Van Meekeren

2005-10-17 14:19:45 EDT

NOTE, Richard this code is not in the builds yet, are you able to test it first?

Comment 5 Richard Gould

2005-10-17 14:29:01 EDT

(In reply to comment #4)
> NOTE, Richard this code is not in the builds yet, are you able to test it first?

Negative. I don't have the Eclipse src checked out right now, nor an appropriate
environment setup. (Is there something like a quickstart available? that would help)

If someone makes a release with the code for me, I can try it out. A little
short on time right now though.

Comment 6 Michael Van Meekeren

2005-10-19 16:33:35 EDT

how about I release it to HEAD, then you could take the next Integration build
and verify and once that is done we can close this bug?

fix released to head, will be available in nightly builds starting tomorrow, or
the I20051025 Integration build.

Comment 7 Richard Gould

2005-11-03 18:58:39 EST

I have downloaded N20051030-0010-win32 and confirmed that the above patch fixes
this problem.

Is there any chance it will be fixed on 3.1.x?

Thanks!

Richard

Comment 8 Eric Moffatt

2005-11-04 09:29:55 EST

MVM, could you please apply this patch for me??
Thanks

Comment 9 Michael Van Meekeren

2005-11-04 10:51:03 EST

fixed in M3.  marking bug as 3.1.2 and leaving open.  Once there is a plan to
build 3.1.2 we can discuss getting this in.

Comment 10 Douglas Pollock

2005-11-15 17:03:31 EST

3.1.2 builds are starting with M20051116-0800.

Comment 11 Eric Moffatt

2005-12-07 13:01:33 EST

This patch has already been applied to the maintenance branch by MVM on Nov 11th...

Comment 12 Karice McIntyre

2005-12-07 13:13:14 EST

Eric, I guess this bug can be marked resolved-fixed then?

Comment 13 Eric Moffatt

2005-12-07 15:17:11 EST

Marking as FIXED since the change is already in the maintenance branch...

Comment 14 Michael Van Meekeren

2006-01-10 09:18:29 EST

verified by looking at the code on Motif - 3.1.2 RC0 M20060109-1200

Comment 15 Michael Van Meekeren

2006-01-10 09:49:42 EST

verified by looking at the code on Motif - 3.1.2 RC0 M20060109-1200

Comment 16 Eric Moffatt

2006-01-10 10:47:15 EST

Verified through source inspection on M20060109-1200...