105809 – Mnemonics are programmatically changed, should not be

Bug 105809 - Mnemonics are programmatically changed, should not be

Summary: Mnemonics are programmatically changed, should not be

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	3.1.1
Hardware:	PC All

Importance:	P2 normal (vote)
Target Milestone:	3.1.1
Assignee:	Tod Creasey
QA Contact:

URL:
Whiteboard:
Keywords:	nl

Depends on:
Blocks:	105726 105731 105837
	Show dependency tree

Reported:	2005-08-02 11:47 EDT by Karice McIntyre
Modified:	2005-09-08 08:08 EDT (History)
CC List:	2 users (show)

See Also:

Attachments
Patch against markers.internal (33.08 KB, patch) 2005-08-02 14:26 EDT, Tod Creasey	no flags	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Karice McIntyre

2005-08-02 11:47:23 EDT

The MnemonicAssigner class in IDE plugin changes the mnemonic that was assigned 
to a string in the .properties file.  We should not do this as the translators 
will use what is in the .properties file as the assigned mnemonic for every 
translated language.

We should remove this for 3.2, probably not necessary for 3.1.1

Comment 1 Karice McIntyre

2005-08-02 12:11:08 EDT

Hmm, I may need to reconsider my comment about this beug not needing to be 
fixed for 3.1.1 as this blocks bug 105726 and is also the cause of bug 105731.

Comment 2 Tod Creasey

2005-08-02 13:35:19 EDT

This is causing us some serious translation problems as well as it does not work
for languages where the mnemonic is not in the String (all DBCS languages).

This does not break anything but we may want to consider it for 3.1.1.

Comment 3 Tod Creasey

2005-08-02 14:26:11 EDT

Created attachment 25577 [details]
Patch against markers.internal

We should apply this patch to 3.1.1. We will end up with 4 indentical mnemonics
for this dialog but at least we won't have the extra tags.

For 3.2 we should add some extra Strings but I don't want to do this for 3.1.1
as this will cause too much work for the translators and it is better to have
duplicate mnemonics rather than extra English Strings.

Comment 4 Tod Creasey

2005-08-02 14:26:58 EDT

Approved for 3.1.1 by Karice and Tod. Final word from MVM.

Comment 5 Tod Creasey

2005-08-02 15:17:41 EDT

Patch released to 3.1.1 Stream and for 3.2 build >20050802

Comment 6 Tod Creasey

2005-08-09 14:58:19 EDT

Verified in 20050808

Comment 7 Michael Van Meekeren

2005-09-07 17:00:28 EDT

So the special code in MnemonicAssigner was finding duplicates and changing them?

Comment 8 Karice McIntyre

2005-09-07 17:08:16 EDT

yes, that is correct.

Comment 9 Michael Van Meekeren

2005-09-07 17:11:33 EDT

I've reopened bug 69423 as a result of this change

Comment 10 Tod Creasey

2005-09-08 08:08:50 EDT

yes