Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 105807 - Toolbars are floating in the middle of views
Summary: Toolbars are floating in the middle of views
Status: CLOSED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: All All
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 79154 106161 106487 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-08-02 11:38 EDT by Tod Creasey CLA
Modified: 2005-09-14 10:29 EDT (History)
6 users (show)

See Also:


Attachments
Screenshot (18.07 KB, image/png)
2005-08-02 11:45 EDT, Tod Creasey CLA
no flags Details
screenshot of "missing" toolbar in Package Explorer (27.76 KB, image/x-png)
2005-08-09 13:46 EDT, Boris Bokowski CLA
no flags Details
editor toolbars messed up (25.20 KB, image/x-png)
2005-08-09 13:49 EDT, Boris Bokowski CLA
no flags Details
Patch the outline toolbar so it doesn't linger (904 bytes, patch)
2005-08-15 10:09 EDT, Paul Webster CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tod Creasey CLA 2005-08-02 11:38:56 EDT
20050802

I am not sure how this occured but I ended up with an outline view with 2
toolbars  - one in the correct place and one floating in the middle of my view
(screenshot to come).

Switching perspective back and forth clears this one up.
Comment 1 Tod Creasey CLA 2005-08-02 11:45:40 EDT
Created attachment 25561 [details]
Screenshot
Comment 2 Douglas Pollock CLA 2005-08-05 10:03:57 EDT
I see this too on Linux GTK+.  The toolbars appear to be coming from another 
perspective. 
Comment 3 Kim Horne CLA 2005-08-05 11:32:55 EDT
*** Bug 106161 has been marked as a duplicate of this bug. ***
Comment 4 Paul Webster CLA 2005-08-08 21:18:20 EDT
Still investigating, since initial trials on I20050808 I wasn't able to reproduce.

PW
Comment 5 Boris Bokowski CLA 2005-08-09 13:46:54 EDT
Created attachment 25918 [details]
screenshot of "missing" toolbar in Package Explorer

I don't know if this is related, but I got a white area instead of the Package
Explorer's toolbar after unchecking "Detached" in the (previously detached)
Outline view. Wasn't able to reproduce yet.
Comment 6 Boris Bokowski CLA 2005-08-09 13:49:26 EDT
Created attachment 25920 [details]
editor toolbars messed up

This occurred after changing the screen resolution.
Comment 7 Boris Bokowski CLA 2005-08-09 13:51:11 EDT
I meant to say: view toolbars ended up in the editor area.
Comment 8 Tod Creasey CLA 2005-08-09 13:56:33 EDT
Boris is this on 20050808-2000?
Comment 9 Olivier Thomann CLA 2005-08-09 14:00:11 EDT
Yes, I got it this morning with 20050808-2000, but for me the toolbar ends up on
top of the outliner view.
Comment 10 Kim Horne CLA 2005-08-09 14:08:50 EDT
*** Bug 106487 has been marked as a duplicate of this bug. ***
Comment 11 Boris Bokowski CLA 2005-08-09 18:36:01 EDT
This bug report describes reproducible steps (worked for me right away):

Bug 79154 [Workbench] Outline view toolbar appears above maximized editor

Looks like a duplicate.
Comment 12 Tod Creasey CLA 2005-08-10 08:25:47 EDT
I have just tested the steps in Bug 79154 this using 20050810 and cannot
replicate this issue
Comment 13 Tod Creasey CLA 2005-08-10 08:26:21 EDT
*** Bug 79154 has been marked as a duplicate of this bug. ***
Comment 14 Paul Webster CLA 2005-08-10 19:06:13 EDT
The patch submitted for I20050810 hopefully fixed the moveAbove()/moveBelow()
related problems, but there's another cause here.

I can replicate this problem by starting in the java perspective and switching
to the debug perspective.

Switch back to Java, open a couple of java files, and the outline view seems fine.

Open a non-outline file, like a properties or text, and then switch back to a
java file.

Now the outline has it's toolbar in the middle of the outline view.

It seems when switching back from the debug perspective to the java perspective,
one of the presentation listeners is not being updated.  The toolbar is being
placed correctly when switching back to the java file, and then the second
listener repositions it in the middle of outline view.

Switching to another Java file puts the toolbar back.

The investigation continues.

PW
Comment 15 Paul Webster CLA 2005-08-15 10:09:55 EDT
Created attachment 26104 [details]
Patch the outline toolbar so it doesn't linger

The PresentationPart was keeping it's property listeners between perspective
switching.  It looks like some PresentationPart/ViewPane fuctionality was
refactored into PresentablePart#enableInputs() and
PresentablePart#enableOutputs(), but PartStack was only calling enableInputs(),
not enableOutputs().

PW
Comment 16 Tod Creasey CLA 2005-08-15 10:56:41 EDT
Patch released for build >20050815
Comment 17 Paul Webster CLA 2005-09-14 10:29:30 EDT
Done and verified.
PW