Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 105268 - JSP Translation JUnit failures in RC build on Linux
Summary: JSP Translation JUnit failures in RC build on Linux
Status: CLOSED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: jst.jsp (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P4 major (vote)
Target Milestone: ---   Edit
Assignee: David Williams CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-26 23:36 EDT by David Williams CLA
Modified: 2006-11-28 15:37 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2005-07-26 23:36:22 EDT 
Part of the fix for bug 103306 caused regressions in JUnit tests involving JSP
translations (which *would* be seen by end users) -- on Linux, they are ok on
windows (as the end-user funtion would be too). 

I have reverted part of the fix for bug 103306, which will allow JSP Translation
tests to work as expected, but I am unclear if this still means bug 103306 is
not fixed, or if there are other "include" resolution cases not handled correctly. 

Much code is in a "confused" state having "hacked around" previous issues 
with file:// vs file:/// ... some of the hacks are not incorrect with other
fixes, but others, apparently, are still needed [or, most likely, all need to 
be removed eventually ... the trick is to minimize changes for 0.7].  

See bug 103607 for some interesting background discussion of file:// vs. file://
(and file:/ and file:device:) 

See also bug 100708 and (its patch in its comment 8) for some tangential
discussion of how the Eclipse platform treats "platform:" differently on 
windows vs. non-windows systems. I mention this since I think some of the code
to "work around" file and uri issues *might* be improved by using more platform
API, such as IResource getLocation?
Comment 1 David Williams CLA 2005-07-26 23:45:35 EDT 
To be clear, the "fix" I reverted was in
FileBufferModelManager

I did *not* revert the "fix" in 
ComponentResolver

please confirm is this alone is enough to fix 103306 and 
leave JSP include translation working correctly for now. 
We can do the "pure fix" later, if we are in s steady state now.
Comment 2 Nitin Dahyabhai CLA 2005-07-27 00:31:09 EDT 
CCing Lawrence, since he was able to verify that reverting
FileBufferModelManager didn't regress bug 103306.
Comment 3 David Williams CLA 2005-07-27 15:54:44 EDT 
I have opened bug 105369 to track further fixes in this area post 0.7.
Comment 4 David Williams CLA 2005-07-27 15:55:23 EDT 
since unit tests passed and basic functions work, will close this one as fixed.
Comment 5 David Williams CLA 2005-07-28 11:09:28 EDT 
I accidently changed title of this one (while making follow up item).
Comment 6 John Lanuti CLA 2006-11-28 15:37:20 EST 
This is part of a mass update to close out all stale WTP defects already verified by the reporter but awaiting closure by the assignee.  If you feel this defect was closed inappropriately, please reopen.

Thanks, John Lanuti