Community
Participate
Working Groups
Target for 3.1.1 release (NL release). In Eclipse 3.1, icons are being supplied for BiDi locales that will appear as if the icon has been reversed. For all plugins that supply icons, some code changes are required to support this that do not appear to be present when running Eclipse in a BiDi locale (get BiDi fragments then run Eclipse with program argument -nl ar_EG). The following 2 items need to be checked: 1. Paths to icons/images that can appear flipped must be prefixed with $nl$/ (e.g. $nl$/ICON_PATH) - this includes paths to icons and images in plugin.xml. 2. Must use Platform.find(Bundle, Path) to create the URL that is used to create the image descriptor. See Tod's Eclipse blog entry for more details on the code changes required. http://todcreaseyeclipse.blogspot.com/ NOTE: Only icons that have the possibility of being flipped need to have this prefix added - you can leave the paths of other icons as they are for 3.1.1 if you want to keep changes to a minimum. You can get the BiDi nl fragments from Cam-Thu Le so that you can see which of your icons have a reversed counterpart in BiDi locales. The following plugins of this component have been identified as requiring this check: *org.eclipse.debug.ui Questions about this issue can be directed to Karice McIntyre or Tod Creasey.
Created attachment 25338 [details] org.eclipse.debug.ui project patch to fix icon paths I used this plugin to help identify and remedy the problem originally reported in bug 105008. This patch, based on 3.2 (HEAD) stream, fixes the problem of reversed icons not appearing when running under a BiDi locale by adding $nl$/ to the icon path and using Platform.find(Bundle, Path) to create URL required to create the ImageDescriptors for each icon. These changes also need to be made to the R3.1 maintenance stream.
Karice, you mention that we can leave the path of icons that will never be flipped as they are for 3.1.1. Does this mean that we can do the same for 3.2, or is the $nl$ fragment necessary for all icons in 3.2. Other than minimizing the number of changes, is there a reason not to just change all icons now?
The $nl$/ part of the path is not mandatory for all icon paths in 3.2. So there is no reason that I am aware of that should prevent you from changing all of your paths in the 3.2 stream to include the $nl$/ part.
Created attachment 25376 [details] updated patch $nl$'d all icons in plugin.xml
released patch to HEAD and 3_1_maintenance branches
Darin, please verify
Verified.
