105261 – [BIDI] need to add $nl$/ to icon paths for reversed icons

Bug 105261 - [BIDI] need to add $nl$/ to icon paths for reversed icons

Summary: [BIDI] need to add $nl$/ to icon paths for reversed icons

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	Text (show other bugs)
Version:	3.1
Hardware:	PC All

Importance:	P2 normal (vote)
Target Milestone:	3.1.1
Assignee:	Dani Megert
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	105008
	Show dependency tree

Reported:	2005-07-26 22:15 EDT by Karice McIntyre
Modified:	2005-08-09 08:42 EDT (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Karice McIntyre

2005-07-26 22:15:46 EDT

Target for 3.1.1 release (NL release).

In Eclipse 3.1, icons are being supplied for BiDi locales that will appear as 
if the icon has been reversed.  For all plugins that supply icons, some code 
changes are required to support this that do not appear to be present when 
running Eclipse in a BiDi locale (get BiDi fragments then run Eclipse with 
program argument -nl ar_EG).  The following 2 items need to be checked:
1. Paths to icons/images that can appear flipped must be prefixed with $nl$/ 
(e.g. $nl$/ICON_PATH) - this includes paths to icons and images in plugin.xml.
2. Must use Platform.find(Bundle, Path) to create the URL that is used to 
create the image descriptor.
See Tod's Eclipse blog entry for more details on the code changes required. 
http://todcreaseyeclipse.blogspot.com/

NOTE: Only icons that have the possibility of being flipped need to have this 
prefix added - you can leave the paths of other icons as they are for 3.1.1 if 
you want to keep changes to a minimum.  You can get the BiDi nl fragments from 
Cam-Thu Le so that you can see which of your icons have a reversed counterpart 
in BiDi locales.  

The following plugins of this component have been identified as requiring this 
check:
*org.eclipse.ui.editors

Questions about this issue can be directed to Karice McIntyre or Tod Creasey.

Comment 1 Tom Hofmann

2005-07-27 03:48:45 EDT

Katrice, do you have a list of the icons that need to be NLSed in the text
component?

Comment 2 Tom Hofmann

2005-07-27 03:51:43 EDT

Identified these:

icons/full/ctool16/last_edit_pos.gif
icons/full/dtool16/last_edit_pos.gif
icons/full/etool16/last_edit_pos.gif

Comment 3 Karice McIntyre

2005-07-27 10:44:07 EDT

The icons listed are the ones I found to have a reversed counterpart.

Comment 4 Dani Megert

2005-08-03 08:27:42 EDT

In addition MarkerAnnotationPreferences is affected.

Comment 5 Dani Megert

2005-08-03 11:17:14 EDT

Fixed in HEAD and R3_1_maintenance.

Comment 6 Markus Keller

2005-08-09 07:06:58 EDT

start verifying...

Comment 7 Markus Keller

2005-08-09 08:42:22 EDT

Verified in M20050804-1200 and I20050808-2000 that all icons in
org.eclipse.ui.editors are nl-aware.