Community
Participate
Eclipse IDE
Target for 3.1.1 release (NL release). In Eclipse 3.1, icons are being supplied for BiDi locales that will appear as if the icon has been reversed. For all plugins that supply icons, some code changes are required to support this that do not appear to be present when running Eclipse in a BiDi locale (get BiDi fragments then run Eclipse with program argument -nl ar_EG). The following 2 items need to be checked: 1. Paths to icons/images that can appear flipped must be prefixed with $nl$/ (e.g. $nl$/ICON_PATH) - this includes paths to icons and images in plugin.xml. 2. Must use Platform.find(Bundle, Path) to create the URL that is used to create the image descriptor. See Tod's Eclipse blog entry for more details on the code changes required. http://todcreaseyeclipse.blogspot.com/ NOTE: Only icons that have the possibility of being flipped need to have this prefix added - you can leave the paths of other icons as they are for 3.1.1 if you want to keep changes to a minimum. You can get the BiDi nl fragments from Cam-Thu Le so that you can see which of your icons have a reversed counterpart in BiDi locales. The following plugins of this component have been identified as requiring this check: *org.eclipse.externaltools *org.eclipse.ant.ui Questions about this issue can be directed to Karice McIntyre or Tod Creasey.
Created attachment 25384 [details] patch for ant.ui Fixes ant.ui plugin. Not sure about AntUIImages. It has a public method setLocalImageDescriptors(IAction, String) and I'm not clear on the purpose of the method. I suspect that it's old code because the method is not referenced anywhere. Patch simply removes the method and a few private methods that were no longer called. Going to run with the code locally for a while before releasing. DarinS, do you know if this patch is safe?
released patch to 3_1_maintenance branch and HEAD
DarinS, please verify
Verified.