105071 – Incorrect handling for debugger's continue-launch-despite-compile-errors dialog

Bug 105071 - Incorrect handling for debugger's continue-launch-despite-compile-errors dialog

Summary: Incorrect handling for debugger's continue-launch-despite-compile-errors dialog

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	Debug (show other bugs)
Version:	3.1
Hardware:	PC Windows XP

Importance:	P3 normal (vote)
Target Milestone:	3.1.2
Assignee:	Darin Wright
QA Contact:

URL:
Whiteboard:
Keywords:

Duplicates (4):	105102 107322 117883 119323 (view as bug list)
Depends on:
Blocks:

Reported:	2005-07-25 15:57 EDT by John Cortell
Modified:	2009-01-12 08:39 EST (History)
CC List:	5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description John Cortell

2005-07-25 15:57:02 EDT

When launching a (CDT) session for a project that has a compile error, the user 
is asked whether he'd like to continue with the launch all the same. The launch 
is cancelled regardless of whether the user hits Yes or No. The reason is a bug 
in the platform function:

org.eclipse.debug.internal.ui.launchConfigurations.
CompileErrorPromptStatusHandler.handleStatus()

The code checks for a return code of IDialogConstants.OK_ID when it should be 
checking for IDialogConstants.YES_ID.

John

Comment 1 Darin Wright

2005-07-26 09:59:07 EDT

*** Bug 105102 has been marked as a duplicate of this bug. ***

Comment 2 Kevin Barnes

2005-07-26 16:13:41 EDT

fixed CompileErrorPromptStatusHandler in HEAD.

Comment 3 Kevin Barnes

2005-07-26 16:14:18 EDT

Darin, please verify

Comment 4 Darin Wright

2005-08-05 10:36:20 EDT

Verified.

Comment 5 Nobody - feel free to take it

2005-08-18 14:51:14 EDT

*** Bug 107322 has been marked as a duplicate of this bug. ***

Comment 6 Guy

2005-08-28 07:27:10 EDT

I installed CDT3.0 and the problem still happens to me even though the bug is 
marked as fixed. When does this fix going to be shown?

Comment 7 Kevin Barnes

2005-08-28 08:10:48 EDT

The fix is in all integration builds since Aug 2, 2005.
Note that this is a bug in Platform-Debug, not CDT.

Comment 8 Nobody - feel free to take it

2005-11-24 16:44:44 EST

*** Bug 117883 has been marked as a duplicate of this bug. ***

Comment 9 Nobody - feel free to take it

2005-11-24 16:47:45 EST

Is it possible to submit this fix to the 3.1.x branch? The CDT 3.0.x is not compatible with Eclipse 3.2 because of the API changes in the AbstractTextEditor. And the fix is trivial.

Comment 10 Darin Wright

2005-11-24 16:49:46 EST

Re-open for 3.1.2

Comment 11 Darin Wright

2005-11-30 14:45:52 EST

Fixed in 3.1.2 branch.

Comment 12 Nobody - feel free to take it

2005-12-05 17:11:14 EST

*** Bug 119323 has been marked as a duplicate of this bug. ***

Comment 13 Darin Wright

2005-12-08 09:00:02 EST

Verified.