Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 104558 - [Workbench] [RCP] Default values for WorkbenchWindow.getPerspectiveBarVisible/CoolBarVisible do not match the values provided by the configurer
Summary: [Workbench] [RCP] Default values for WorkbenchWindow.getPerspectiveBarVisible...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 3.2 M2   Edit
Assignee: Boris Bokowski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 104280
  Show dependency tree
 
Reported: 2005-07-20 14:38 EDT by Kim Horne CLA
Modified: 2005-09-20 15:36 EDT (History)
2 users (show)

See Also:

Attachments
Test case (patch for WorkbenchWindowConfigurerTest.java) (2.50 KB, patch)
2005-07-21 16:19 EDT, Boris Bokowski CLA 		no flags Details | Diff
fix for this bug (patch to org.eclipse.ui.workbench) (1.02 KB, patch)
2005-07-21 16:20 EDT, Boris Bokowski CLA 		no flags Details | Diff
updates the test (patch to o.e.ui.tests.rcp) (1.37 KB, patch)
2005-08-10 13:08 EDT, Boris Bokowski CLA 		no flags Details | Diff
update to make the new test pass (patch to o.e.ui.workbench) (2.05 KB, patch)
2005-08-10 13:09 EDT, Boris Bokowski CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kim Horne CLA 2005-07-20 14:38:37 EDT 
3.1

If you use IWorkbenchWindowConfigurer.setShowCoolBar/PerspectiveBar to be false the bars will not be 
created (as expected) but this value is not used to populate the fields on WorkbenchWindow which are true 
by default.  The result is that querying the window for visibility of these items returns true even when they 
are not visible.

MvM, feel free to punt this back to me if you don't have time to deal with it.  It's a requirement for bug 
104280.
Comment 1 Michael Van Meekeren CLA 2005-07-20 15:45:54 EDT 
Boris is messing around with coolbar etc... right now.
Comment 2 Boris Bokowski CLA 2005-07-21 16:19:29 EDT 
Created attachment 25153 [details]
Test case (patch for WorkbenchWindowConfigurerTest.java)
Comment 3 Boris Bokowski CLA 2005-07-21 16:20:23 EDT 
Created attachment 25154 [details]
fix for this bug (patch to org.eclipse.ui.workbench)
Comment 4 Boris Bokowski CLA 2005-07-21 16:21:15 EDT 
Kim, could you release the test case and the fix for me? Thanks!
Comment 5 Kim Horne CLA 2005-07-27 09:53:24 EDT 
Sorry for the delay - patches submitted.
Comment 6 Kim Horne CLA 2005-08-09 13:54:44 EDT 
This still doesn't appear to be working.
Comment 7 Kim Horne CLA 2005-08-09 13:56:58 EDT 
Steps to witness:

1) Check out the browser example from CVS and add the following lines to the preWindowOpen() 
method of the BrowserWindowAdvisor:

configurer.setShowPerspectiveBar(false);
configurer.setShowCoolBar(false);

2) Set a breakpoint at line 190 of the CarbonUIEnhancer class (on OS X of course).  

3) launch a debug workspace and step through the next two statements.  Both coolBarInitiallyVsible and 
perspectiveBarInitiallyVsible will be true.
Comment 8 Boris Bokowski CLA 2005-08-09 14:45:04 EDT 
The CarbonUIEnhancer code is called from a syncExec in an earlyStartup. We 
need a test case involving an earlyStartup extension.
Comment 9 Douglas Pollock CLA 2005-08-10 12:11:17 EDT 
Is this bug going to be fixed for M1?  If not, then please change the 
milestone....
Comment 10 Boris Bokowski CLA 2005-08-10 12:16:03 EDT 
Changed target milestone to 3.2 M2.
Comment 11 Boris Bokowski CLA 2005-08-10 12:58:25 EDT 
The values are not set in the case of the browser example because the 
BrowserWindowAdvisor implements createWindowContents, replacing the default 
behaviour which sets the booleans.
Comment 12 Boris Bokowski CLA 2005-08-10 13:08:38 EDT 
Created attachment 25984 [details]
updates the test (patch to o.e.ui.tests.rcp)
Comment 13 Boris Bokowski CLA 2005-08-10 13:09:03 EDT 
Created attachment 25985 [details]
update to make the new test pass (patch to o.e.ui.workbench)
Comment 14 Boris Bokowski CLA 2005-08-10 13:14:03 EDT 
Kim, could you commit the patches for me (after 3.2 M1)? Thanks!
Comment 15 Kim Horne CLA 2005-08-15 12:05:04 EDT 
Patches committed.
Comment 16 Kim Horne CLA 2005-09-20 15:36:38 EDT 
Verified in I20050920-0010 by m4d h4x0r1n6 the browser example