Community
Participate
Working Groups
Eclipse fails to show history for files that are locked using "cvs admin -L" command. Here is a stack trace I see in .log !ENTRY org.eclipse.ui 4 0 2005-07-11 15:02:49.281 !MESSAGE Failed to execute runnable (java.lang.NumberFormatException: For input string: "2 locked by: cvslock;") !STACK 0 org.eclipse.swt.SWTException: Failed to execute runnable (java.lang.NumberFormatException: For input string: "2 locked by: cvslock;") at org.eclipse.swt.SWT.error(SWT.java:2942) at org.eclipse.swt.SWT.error(SWT.java:2865) at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:126) at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3057) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2716) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1699) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1663) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:367) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:143) at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:103) at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:226) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:376) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:163) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at org.eclipse.core.launcher.Main.invokeFramework(Main.java:334) at org.eclipse.core.launcher.Main.basicRun(Main.java:278) at org.eclipse.core.launcher.Main.run(Main.java:973) at org.eclipse.core.launcher.Main.main(Main.java:948) Caused by: java.lang.NumberFormatException: For input string: "2 locked by: cvslock;" at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48) at java.lang.Integer.parseInt(Integer.java:456) at java.lang.Integer.<init>(Integer.java:620) at org.eclipse.team.internal.ccvs.ui.VersionCollator.getIntSegments(VersionCollator.java:55) at org.eclipse.team.internal.ccvs.ui.VersionCollator.compare(VersionCollator.java:27) at org.eclipse.team.internal.ccvs.ui.HistoryTableProvider$HistorySorter.compareColumnValue(HistoryTableProvider.java:195) at org.eclipse.team.internal.ccvs.ui.HistoryTableProvider$HistorySorter.compare(HistoryTableProvider.java:180) at org.eclipse.jface.viewers.ViewerSorter$1.compare(ViewerSorter.java:177) at java.util.Arrays.mergeSort(Arrays.java:1284) at java.util.Arrays.mergeSort(Arrays.java:1296) at java.util.Arrays.mergeSort(Arrays.java:1296) at java.util.Arrays.mergeSort(Arrays.java:1296) at java.util.Arrays.mergeSort(Arrays.java:1296) at java.util.Arrays.mergeSort(Arrays.java:1296) at java.util.Arrays.sort(Arrays.java:1223) at org.eclipse.jface.viewers.ViewerSorter.sort(ViewerSorter.java:175) at org.eclipse.jface.viewers.StructuredViewer.getSortedChildren(StructuredViewer.java:909) at org.eclipse.jface.viewers.TableViewer.internalRefreshAll(TableViewer.java:798) at org.eclipse.jface.viewers.TableViewer.internalRefresh(TableViewer.java:748) at org.eclipse.jface.viewers.TableViewer.internalRefresh(TableViewer.java:737) at org.eclipse.jface.viewers.StructuredViewer$7.run(StructuredViewer.java:1264) at org.eclipse.jface.viewers.StructuredViewer.preservingSelection(StructuredViewer.java:1201) at org.eclipse.jface.viewers.StructuredViewer.refresh(StructuredViewer.java:1262) at org.eclipse.jface.viewers.StructuredViewer.refresh(StructuredViewer.java:1221) at org.eclipse.team.internal.ccvs.ui.HistoryView$3.run(HistoryView.java:153) at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35) at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:123) ... 18 more
Created attachment 24579 [details] proposed fix The problem occures when revisions are locked using "admin -l<rel>" command, not "admin -L" as I originally thought. Here is an example of what gets returned from CVS server for such revisions (as seen in the console when detailed protocol output is enabled) M revision 1.2.2.3 locked by: igorf; M date: 2005/05/16 23:48:15; author: igorf; state: Exp; lines: +1 -0 M added new file Hope this helps.
Thanks for the patch. I'll apply it in the next week or so (if I don' get to it in the next week please ping me through this bug as a friendly reminder;-)
Patch released.
Thank you, Micheal. One question though - did you fix this problem in 3.1 (branch?) too or in 3.2 only?
*** Bug 44438 has been marked as a duplicate of this bug. ***
It is fixed in 3.2. I don't think this is critical enough for 3.1.1 (i.e. the problem has been there since 2.0 so it can't be that critical).
Verified in I20050808-2000.
*** Bug 131161 has been marked as a duplicate of this bug. ***
