Community
Participate
Working Groups
see attached image. If i move the shell to the top of the screen and make it narrow the key assist is a small shell, but on left right, bottom it works fine.
Created attachment 24393 [details] small popup
If the window itself is small, then the key assist will open small. This is intentional. It is intended to minimize the amount of the workbench window it can occupy. The only situation I can see this being a problem is if the key assist were to appear in a small RCP application ... like an instant messaging client. The menu item (Help > Key Assist...) is already limited to IDE applications. I will move the key binding to IDE as well. This means that an RCP application will only really get the assist showing if they bind it themselves, use multi-stroke bindings or the user creates their own binding to it. I believe these three cases are fairly indicative of a larger window. I'm pretty sure this isn't exactly what you guys are hoping for, but this seems like a pretty extreme case. Without concrete use cases as to why this would be a problem, it would be hard to adjust the sizing algorithm.
I'd suggest that additionally it should have a minimum size of 1 or 2 rows so that it never opens in a completely useless state as in the image.
Can you show me an image of a usable workbench window where one line does not appear in the key assist dialog?
Created attachment 24441 [details] other dropdowns I guess my comment is that if your drop down is not going to be resizable (as many others are) then it should never be a size that looks goofy and is not usable.
As part of this change, the showKeyAssist command was moved up to org.eclipse.ui.ide. Just wondering why?
The show key assist command was not moved, only the key binding. Please see comment #2.
Verified that the show key assist command exists in "org.eclipse.ui" and that the binding and menu item appear in "org.eclipse.ui.ide"
