Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 102259 - [launcher] ICO file not used if launcher name is not changed
Summary: [launcher] ICO file not used if launcher name is not changed
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal with 1 vote (vote)
Target Milestone: 3.2 M6   Edit
Assignee: pde-build-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-29 23:20 EDT by Wassim Melhem CLA
Modified: 2006-02-28 08:57 EST (History)
2 users (show)

See Also:

Attachments
patch (1.44 KB, patch)
2006-02-24 11:10 EST, Andrew Niefer CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wassim Melhem CLA 2005-06-29 23:20:35 EDT 
3.1

If I don't change the launcher name on the Branding page of the product 
editor, the ICO file I select is not used.  The end product shows the eclipse 
icon.

If I change the launcher name to 'Wassim', my custom ICO file is used.
Comment 1 Nick Edgar CLA 2005-06-30 13:31:48 EDT 
See also bug 102028.
Comment 2 Jason Miller CLA 2005-12-21 10:39:10 EST 
Just ran into this myself on eclipse:

Version: 3.2.0
Build id: I20051102-1600
Comment 3 Kenneth Evans, Jr. CLA 2006-01-21 18:27:06 EST 
It doesn't change for me when I do rename it.  I have tried capturing the eclipse .ico, changing the pixels and using that.  It continues to use the original one.  The number of types (7) in the original does not agree with the number of bitmaps, and they also have different resolutions.  The bitmaps don't work either, for me.  There are a lot of problems, and the documentation is lacking.  See the thread at eclipse.platform.rcp titled "How to specify launcher icons for product."  One should not have to specify all the types, if they are not needed.  Few people use 16-bit color.  There should also be a warning message during export if there is a problem.
Comment 4 Wassim Melhem CLA 2006-01-21 18:48:56 EST 
the last we heard about ICO requirements are those in bug 118811 comment 5.  Give that a try.

Pascal, can you please talk to Chris Cornu or whoever wrote the branding task to get an official word on these vague-at-best requirements.
Comment 5 Andrew Niefer CLA 2006-02-24 11:10:36 EST 
Created attachment 35309 [details]
patch

This patch fixes the problem where the branding does not take place if the launcher is not renamed.

As for issues with ico files or bitmaps not working, we can only replace images that match the size and bitdepth of those already in the exe.  In addition to bug 118811 comment 5, see also bug 121735
Comment 6 Pascal Rapicault CLA 2006-02-28 08:57:07 EST 
Patch released in HEAD.