102193 – [Organize Imports] generic method problem

Bug 102193 - [Organize Imports] generic method problem

Summary: [Organize Imports] generic method problem

Status:	VERIFIED FIXED

Alias:	None

Product:	JDT
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	3.1
Hardware:	Macintosh All

Importance:	P3 critical (vote)
Target Milestone:	3.1.1
Assignee:	Martin Aeschlimann
QA Contact:

URL:
Whiteboard:
Keywords:

Duplicates (1):	102194 (view as bug list)
Depends on:
Blocks:

Reported:	2005-06-29 15:36 EDT by Jamieson Cobleigh
Modified:	2005-08-09 06:05 EDT (History)
CC List:	4 users (show)

See Also:

Attachments
Proposed fix (1.69 KB, patch) 2005-06-29 19:25 EDT, Olivier Thomann	no flags	Details \| Diff
patch for jdt.ui (1.38 KB, patch) 2005-07-12 09:38 EDT, Martin Aeschlimann	no flags	Details \| Diff
patch for jdt.ui.tests (3.27 KB, patch) 2005-07-12 09:39 EDT, Martin Aeschlimann	no flags	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jamieson Cobleigh

2005-06-29 15:36:46 EDT

In Eclipse 3.1, if my code has the following line:
  Collections.<MyType>emptySet();

and I issue the Organize Imports command, MyType will be removed from the
imports unless it is used elsewhere in that class.

Comment 1 Olivier Thomann

2005-06-29 17:30:14 EDT

*** Bug 102194 has been marked as a duplicate of this bug. ***

Comment 2 Olivier Thomann

2005-06-29 19:25:56 EDT

Created attachment 24163 [details]
Proposed fix

I added some visit method.

Comment 3 Olivier Thomann

2005-06-29 19:26:42 EDT

Move to JDT/UI.

Comment 4 Dirk Baeumer

2005-06-30 17:41:21 EDT

Martin, something we might consider for 3.1.1 if fix is easy.

Comment 5 Martin Aeschlimann

2005-07-12 09:38:40 EDT

Created attachment 24603 [details]
patch for jdt.ui

Comment 6 Martin Aeschlimann

2005-07-12 09:39:03 EDT

Created attachment 24604 [details]
patch for jdt.ui.tests

Comment 7 Martin Aeschlimann

2005-07-12 09:44:21 EDT

Dirk and Markus, can you please review?

Comment 8 Martin Aeschlimann

2005-07-12 12:01:51 EDT

released in 3.2 stream > 20050712

Comment 9 Dirk Baeumer

2005-07-26 13:29:20 EDT

Patch looks fine for me.

Comment 10 Martin Aeschlimann

2005-07-27 09:05:09 EDT

reviewed by Tom, released in 3.1.1

Comment 11 Dirk Baeumer

2005-08-09 05:59:48 EDT

Start verifying...

Comment 12 Dirk Baeumer

2005-08-09 06:05:12 EDT

Verified on M20050804-1200.