Bug 101805 - Whitespace should be recognized in dynamic help view
Summary: Whitespace should be recognized in dynamic help view
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1.1   Edit
Assignee: Platform-Help-Inbox CLA Friend
QA Contact:
URL:
Whiteboard:
Keywords:
: 102836 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-06-26 21:11 EDT by Jennifer Calder CLA Friend
Modified: 2005-07-28 14:25 EDT (History)
2 users (show)

See Also:

Attachments
The fix for hardcoded new line characters in context help. (911 bytes, patch)
2005-07-19 14:41 EDT, Dejan Glozic CLA Friend 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jennifer Calder CLA Friend 2005-06-26 21:11:29 EDT 
Prior to 3.1, whitespace was recognized in infopops. It was removed for the new
dynamic help view, but I'm not sure why. If there was not a compelling reason
for doing this, then please return whitespace recognition back to the way it
was. If it is not returned, those of us who implement dynamic help will have to
rewrite many of our context descriptions (for example, most of my pre-3.1
descriptions contain whitespace formatting).
Comment 1 Konrad Kolosowski CLA Friend 2005-07-19 13:34:51 EDT 
*** Bug 102836 has been marked as a duplicate of this bug. ***
Comment 2 Dejan Glozic CLA Friend 2005-07-19 13:36:57 EDT 
Would 3.1.1 be good enough for you as a fix delivery vehicle?
Comment 3 Dejan Glozic CLA Friend 2005-07-19 14:40:27 EDT 
Text from context help is wrapped in XML markup and passed directly to the 
FormText widget. This widget does not handle hard coded new lines because it 
performs white space normalization. An explicit <br/> is required to make it 
wrap at a particular point.

The fix is simple and involves conversion of new line characters into <br/> 
element before passing the text to FormText widget. I will attach the patch.

We will fix this for 3.1.1.
Comment 4 Dejan Glozic CLA Friend 2005-07-19 14:41:57 EDT 
Created attachment 24997 [details]
The fix for hardcoded new line characters in context help.
Comment 5 Jennifer Calder CLA Friend 2005-07-20 10:02:38 EDT 
Speaking for myself only, I can live with 3.1.1 as a fix delivery vehicle. You 
have run this past a few others here - people who are responsible for much 
larger offerings. They should be the ones who decide if we can live with this 
until 3.1.1.
Comment 6 Dejan Glozic CLA Friend 2005-07-20 10:16:55 EDT 
I will rebuild helpui.jar and attach it here to allow you to play with it and 
let us know if there are any side-effects of the fix.
Comment 7 Konrad Kolosowski CLA Friend 2005-07-26 14:19:18 EDT 
Fix released into 3.2 and 3.1.1 builds.
Comment 8 Jennifer Calder CLA Friend 2005-07-28 14:25:34 EDT 
Verified in eclipse-SDK-I20050726-1222-win32.zip - whitespace is now recognized.