Bug 101800 - NPE when opening .product file from CVS Views
Summary: NPE when opening .product file from CVS Views
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1.1   Edit
Assignee: PDE-UI-Inbox CLA Friend
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-26 19:11 EDT by CLA Friend
Modified: 2005-08-12 10:07 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description CLA Friend 2005-06-26 19:11:52 EDT
I have an RCP .product file in a CVS repository.  I open the CVS Resource 
History View, select a version of the file and attempt to Open it from 
the "Open" command in the CVS Resource History View.  A Null Pointer is thrown 
and the file is not displayed.  Log:


!ENTRY org.eclipse.ui 4 0 2005-06-27 00:12:47.953
!MESSAGE Unable to create editor ID org.eclipse.pde.ui.productEditor: An 
unexpected exception was thrown.
!STACK 0
java.lang.NullPointerException
	at org.eclipse.pde.internal.ui.editor.product.ProductEditor.useFeatures
(ProductEditor.java:134)
	at org.eclipse.pde.internal.ui.editor.product.ProductEditor.addPages
(ProductEditor.java:108)
	at org.eclipse.ui.forms.editor.FormEditor.createPages
(FormEditor.java:133)
	at org.eclipse.pde.internal.ui.editor.PDEFormEditor.createPages
(PDEFormEditor.java:226)
	at org.eclipse.ui.part.MultiPageEditorPart.createPartControl
(MultiPageEditorPart.java:241)
	at org.eclipse.ui.internal.EditorReference.createPartHelper
(EditorReference.java:585)
	at org.eclipse.ui.internal.EditorReference.createPart
(EditorReference.java:365)
	at org.eclipse.ui.internal.WorkbenchPartReference.getPart
(WorkbenchPartReference.java:552)
	at org.eclipse.ui.internal.PartPane.setVisible(PartPane.java:283)
	at org.eclipse.ui.internal.presentations.PresentablePart.setVisible
(PresentablePart.java:126)
	at 
org.eclipse.ui.internal.presentations.util.PresentablePartFolder.select
(PresentablePartFolder.java:268)
	at 
org.eclipse.ui.internal.presentations.util.LeftToRightTabOrder.select
(LeftToRightTabOrder.java:65)
	at 
org.eclipse.ui.internal.presentations.util.TabbedStackPresentation.selectPart
(TabbedStackPresentation.java:391)
	at org.eclipse.ui.internal.PartStack.refreshPresentationSelection
(PartStack.java:1102)
	at org.eclipse.ui.internal.PartStack.setSelection(PartStack.java:1051)
	at org.eclipse.ui.internal.PartStack.showPart(PartStack.java:1256)
	at org.eclipse.ui.internal.PartStack.add(PartStack.java:442)
	at org.eclipse.ui.internal.EditorStack.add(EditorStack.java:109)
	at org.eclipse.ui.internal.EditorSashContainer.addEditor
(EditorSashContainer.java:60)
	at org.eclipse.ui.internal.EditorAreaHelper.addToLayout
(EditorAreaHelper.java:212)
	at org.eclipse.ui.internal.EditorAreaHelper.addEditor
(EditorAreaHelper.java:202)
	at org.eclipse.ui.internal.EditorManager.createEditorTab
(EditorManager.java:753)
	at org.eclipse.ui.internal.EditorManager.openEditorFromDescriptor
(EditorManager.java:665)
	at org.eclipse.ui.internal.EditorManager.openEditor
(EditorManager.java:628)
	at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditorBatched
(WorkbenchPage.java:2323)
	at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditor
(WorkbenchPage.java:2258)
	at org.eclipse.ui.internal.WorkbenchPage.access$9
(WorkbenchPage.java:2250)
	at org.eclipse.ui.internal.WorkbenchPage$9.run(WorkbenchPage.java:2236)
	at org.eclipse.swt.custom.BusyIndicator.showWhile
(BusyIndicator.java:69)
	at org.eclipse.ui.internal.WorkbenchPage.openEditor
(WorkbenchPage.java:2231)
	at org.eclipse.ui.internal.WorkbenchPage.openEditor
(WorkbenchPage.java:2204)
	at org.eclipse.team.internal.ccvs.ui.actions.OpenLogEntryAction$1.run
(OpenLogEntryAction.java:85)
	at org.eclipse.team.internal.ccvs.ui.repo.RepositoryManager.run
(RepositoryManager.java:651)
	at org.eclipse.team.internal.ccvs.ui.actions.CVSAction$2.run
(CVSAction.java:347)
	at org.eclipse.team.internal.ccvs.ui.actions.CVSAction$3.run
(CVSAction.java:356)
	at org.eclipse.swt.custom.BusyIndicator.showWhile
(BusyIndicator.java:69)
	at org.eclipse.team.internal.ccvs.ui.actions.CVSAction.run
(CVSAction.java:353)
	at org.eclipse.team.internal.ccvs.ui.actions.OpenLogEntryAction.execute
(OpenLogEntryAction.java:64)
	at org.eclipse.team.internal.ccvs.ui.actions.CVSAction.run
(CVSAction.java:117)
	at org.eclipse.team.internal.ccvs.ui.HistoryView$6.handleEvent
(HistoryView.java:199)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:843)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3080)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2713)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1699)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1663)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench
(Workbench.java:367)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:143)
	at org.eclipse.ui.internal.ide.IDEApplication.run
(IDEApplication.java:103)
	at org.eclipse.core.internal.runtime.PlatformActivator$1.run
(PlatformActivator.java:226)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run
(EclipseStarter.java:376)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run
(EclipseStarter.java:163)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at org.eclipse.core.launcher.Main.invokeFramework(Main.java:334)
	at org.eclipse.core.launcher.Main.basicRun(Main.java:278)
	at org.eclipse.core.launcher.Main.run(Main.java:973)
	at org.eclipse.core.launcher.Main.main(Main.java:948)
Comment 1 CLA Friend 2005-06-26 19:27:40 EDT
This is on Eclipse 3.1 RC4
Comment 2 CLA Friend 2005-06-27 13:08:51 EDT
The NPE also occurs when attempting to open the .product file from the CVS 
Repositories View.
Comment 3 CLA Friend 2005-06-27 14:45:11 EDT
Wondering if this NPE when opening a file is important enough to fix for 3.1 
final?

Comment 4 Wassim Melhem CLA Friend 2005-06-27 14:46:41 EDT
3.1.1
Comment 5 Wassim Melhem CLA Friend 2005-08-12 10:07:13 EDT
Fixed in both 3.1.1 and 3.2

The problem was that there were two places that were referencing the 
early '.prod' extension that never saw the light of day.