Bug 101683 - [WorkbenchParts] Views opened by context enablement are covered up by buttons from Breakpoints View
Summary: [WorkbenchParts] Views opened by context enablement are covered up by buttons...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows 2000
: P2 normal (vote)
Target Milestone: 3.1.1   Edit
Assignee: Paul Webster CLA Friend
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-24 14:29 EDT by Samantha Chan CLA Friend
Modified: 2005-09-26 13:34 EDT (History)
7 users (show)

See Also:

Attachments
Screeb capture showing the problem. (14.45 KB, image/jpeg)
2005-06-24 14:29 EDT, Samantha Chan CLA Friend 		no flags Details
fix new tabs so they request layouts 3.1.1 v01 (2.79 KB, patch)
2005-08-04 15:28 EDT, Paul Webster CLA Friend 		no flags Details | Diff
patch so toolbar area resize requests the layout (1.16 KB, patch)
2005-08-09 10:59 EDT, Paul Webster CLA Friend 		no flags Details | Diff
patch so toolbar area resize requests the layout v02 (1.97 KB, patch)
2005-08-09 13:25 EDT, Paul Webster CLA Friend 		no flags Details | Diff
patch so toolbar area resize requests the layout v03 (1.79 KB, patch)
2005-08-16 11:47 EDT, Paul Webster CLA Friend 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Samantha Chan CLA Friend 2005-06-24 14:29:12 EDT 
To reproduce:
1.  Reset debug perspective.
2.  Bring the Breakpoints View to the top.  
3.  Launch a debug session that opens up a number of views from context 
enablement.  The views are set to open but not to activate.
4.  When the new views are opened, the view labels are covered by the buttons 
from the breakpoints view.

If you switch to another view and back to the Breakpoints View, the buttons get 
moved down and view labels are not covered anymore.

I will attach a screen capture for the problem.
Comment 1 Samantha Chan CLA Friend 2005-06-24 14:29:35 EDT 
Created attachment 23957 [details]
Screeb capture showing the problem.
Comment 2 Darin Wright CLA Friend 2005-06-24 15:12:48 EDT 
Looks similar to bug 72822, but not sure it's the same thing. Moving to UI for 
comment.
Comment 3 Nick Edgar CLA Friend 2005-06-24 15:49:50 EDT 
Should investigate for 3.1.1.
Comment 4 Nick Edgar CLA Friend 2005-06-24 15:50:14 EDT 
Darin provided an example, which I've forwarded to Stefan.
Comment 5 Paul Webster CLA Friend 2005-08-03 10:20:41 EDT 
Darin, thanx for forwarding on the sample, I can reproduce the problem.

I'm guessing the expected behaviour should be:

1. the breakpoint view stays active and on top
2. the context tabs become visible
3. the breakpoint toolbar moves down and doesn't obscure the tabs any more

PW
Comment 6 Darin Wright CLA Friend 2005-08-03 10:42:05 EDT 
Correct on the expected behavior.
Comment 7 Paul Webster CLA Friend 2005-08-04 15:28:56 EDT 
Created attachment 25705 [details]
fix new tabs so they request layouts 3.1.1 v01

This patch focuses on the presentation code.  When a new tab is added the
TabbedStackPresentation is notified of the addition.  For now that just
requests a delayed layout for this stack.

PW
Comment 8 Nick Edgar CLA Friend 2005-08-04 15:30:53 EDT 
Looks good to me.  Please ask Stefan to review too.
Comment 9 Paul Webster CLA Friend 2005-08-04 15:41:43 EDT 
Stefan,

We should review this fix as well on Monday.

PW
Comment 10 Paul Webster CLA Friend 2005-08-08 21:15:51 EDT 
This patch is being reworked.

PW
Comment 11 Paul Webster CLA Friend 2005-08-09 10:59:19 EDT 
Created attachment 25903 [details]
patch so toolbar area resize requests the layout

When the title area proxy is resized, it now requests a layout only on the
PaneFolder (CTabFolder).  Much closer to where the action is.

PW
Comment 12 Paul Webster CLA Friend 2005-08-09 13:25:26 EDT 
Created attachment 25915 [details]
patch so toolbar area resize requests the layout v02

Upon creation,there are a lot of Resize events ... now they can't trigger
recursive layouts.

PW
Comment 13 Paul Webster CLA Friend 2005-08-16 11:47:17 EDT 
Created attachment 26151 [details]
patch so toolbar area resize requests the layout v03

The layout should be done immediately, and not depend on an asyncExec().

PW
Comment 14 Paul Webster CLA Friend 2005-08-16 13:16:47 EDT 
Tod, this should be submitted for 3.1.1, and then I'll regenerate the patch for
HEAD.

PW
Comment 15 Tod Creasey CLA Friend 2005-08-16 14:58:09 EDT 
Patch released for 3.1.1 build >20050815
Comment 16 Tod Creasey CLA Friend 2005-08-16 15:13:14 EDT 
Also released to 3.2 build >20050816
Comment 17 Paul Webster CLA Friend 2005-08-18 10:41:17 EDT 
Released into 3.1.1 and 3.2
Comment 18 Paul Webster CLA Friend 2005-09-20 13:38:03 EDT 
verified in 3.2 I20050920-0010
Comment 19 Paul Webster CLA Friend 2005-09-26 13:34:28 EDT 
Verified in 3.1.1RC2