Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 101358 - [Viewers] ICellModifier#modify method is not transitive
Summary: [Viewers] ICellModifier#modify method is not transitive
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: All All
: P4 enhancement with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Boris Bokowski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-22 16:55 EDT by Alberto Ricart CLA
Modified: 2007-06-21 16:13 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Ricart CLA 2005-06-22 16:55:06 EDT
ICellModifier has:

boolean canModify(Object, property)
Object getValue(Object, property)
void modify(Object, property, value)

There are two things wrong with this:

canModify, getValue, MODIFY? What about setValue?

Worse, both canModify and getValue pass a model Object. modify in many instances can pass some 
lame SWT Item. The javadoc even docs this *bug*. If you know that it could pass Item, you need to call 
getData() on the item, and pass me that instead.

Otherwise it creates a lot of uncertainty in the apis, does this pass this or that.
Comment 1 Boris Bokowski CLA 2005-11-09 17:18:10 EST
Tod, is there a reason why TableEditorImpl.saveEditorValue() does not call
getData() to get the element when calling ICellModifier.modify()?
Comment 2 Boris Bokowski CLA 2007-06-21 16:13:45 EDT
Please look at the new API in 3.3, it is more powerful and hopefully less confusing: Table/TreeViewerColumn.setEditingSupport().