Bug 101329 - NPE while disconnecting folder
Summary: NPE while disconnecting folder
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.1.1   Edit
Assignee: platform-cvs-inbox CLA Friend
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-22 15:18 EDT by Nick Edgar CLA Friend
Modified: 2005-09-26 11:41 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA Friend 2005-06-22 15:18:59 EDT 
build N20050622

- selected org.eclipse.ui/schema in the package explorer
- chose Properties > CVS > Disconnect
- got the following in the log (no feedback in UI)

java.lang.NullPointerException
	at
org.eclipse.team.internal.ccvs.core.resources.EclipseFolder.recursiveUnmanage(EclipseFolder.java:255)
	at
org.eclipse.team.internal.ccvs.core.resources.EclipseFolder.recursiveUnmanage(EclipseFolder.java:260)
	at
org.eclipse.team.internal.ccvs.core.resources.EclipseFolder$2.run(EclipseFolder.java:236)
	at
org.eclipse.team.internal.ccvs.core.resources.EclipseSynchronizer.run(EclipseSynchronizer.java:1450)
	at
org.eclipse.team.internal.ccvs.core.resources.EclipseResource$2.run(EclipseResource.java:268)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:1719)
	at
org.eclipse.team.internal.ccvs.core.resources.EclipseResource.run(EclipseResource.java:265)
	at
org.eclipse.team.internal.ccvs.core.resources.EclipseFolder.unmanage(EclipseFolder.java:232)
	at
org.eclipse.team.internal.ccvs.ui.CVSFolderPropertiesPage$2.run(CVSFolderPropertiesPage.java:160)
	at
org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:113)
Comment 1 Michael Valenta CLA Friend 2005-06-22 15:54:08 EDT 
We need a null check and don't have one. Having said that, the 
getResourceAttributes shouldn't fail and doesn't in most cases. THerefore, I 
don't think this needs to be fixed for 3.1. A good candidate for 3.1.1 though.
Comment 2 Michael Valenta CLA Friend 2005-08-04 11:50:48 EDT 
Fix released t0 3.1.1 and 3.2
Comment 3 Michael Valenta CLA Friend 2005-09-26 11:41:13 EDT 
Verified fixed in M20050923-1430