101328 – Got an error when trying to commit a removal

Bug 101328 - Got an error when trying to commit a removal

Summary: Got an error when trying to commit a removal

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	CVS (show other bugs)
Version:	3.1
Hardware:	PC Windows XP

Importance:	P3 normal (vote)
Target Milestone:	3.1.1
Assignee:	platform-cvs-inbox
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2005-06-22 15:13 EDT by Olivier Thomann
Modified:	2005-09-26 11:43 EDT (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Olivier Thomann

2005-06-22 15:13:31 EDT

Using N0622, select the removal that you want to commit and you will get an
error in the log about the fact that the resource does't exist.
Of course, it doesn't exist, because I want to commit the removed element.
I needed to select the parent to commit that change.

Comment 1 Olivier Thomann

2005-06-22 15:23:21 EDT

Here is the stack trace:
org.eclipse.core.internal.resources.ResourceException: Resource
/org.eclipse.jdt.doc.isv/guide/tmpBCB0.html does not exist.
	at org.eclipse.core.internal.resources.Resource.checkExists(Resource.java:304)
	at org.eclipse.core.internal.resources.Resource.accept(Resource.java:98)
	at org.eclipse.core.internal.resources.Resource.accept(Resource.java:87)
	at
org.eclipse.team.internal.ccvs.core.CVSWorkspaceSubscriber.collectOutOfSync(CVSWorkspaceSubscriber.java:196)
	at
org.eclipse.team.internal.core.subscribers.SubscriberEventHandler.collectAll(SubscriberEventHandler.java:345)
	at
org.eclipse.team.internal.core.subscribers.SubscriberEventHandler.processEvent(SubscriberEventHandler.java:411)
	at
org.eclipse.team.internal.core.BackgroundEventHandler.processEvents(BackgroundEventHandler.java:329)
	at
org.eclipse.team.internal.core.BackgroundEventHandler$1.run(BackgroundEventHandler.java:173)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:76)

I don't think the checkExist() is right for a removal.

Comment 2 Michael Valenta

2005-06-22 15:52:01 EDT

Given that this is rare and there is a workaround, we'll fix it in 3.1.1. The 
problem is that usually the deleted files are phatoms but there are rare cases 
when they are not. Olivier hit on one such case. It doesn't happen for all 
external deletions. To reproduce this:

1) Create an html file outside of Eclipse, refresh the project and commit. In 
the original case, the html file was a temp file created when browser a file 
being edited by an html editor.

2) Delete the html file externally, refresh the project and try to commit the 
deletion.

Comment 3 Michael Valenta

2005-08-04 13:35:43 EDT

Fix released to both 3.1.1 and 3.2

Comment 4 Michael Valenta

2005-09-26 11:43:28 EDT

Verified fixed in M20050923-1430