Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 101029 - Remove log statement from JavaElementLabels
Summary: Remove log statement from JavaElementLabels
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.1 RC4   Edit
Assignee: Dirk Baeumer CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-21 08:45 EDT by Dirk Baeumer CLA
Modified: 2005-06-22 08:33 EDT (History)
3 users (show)

See Also:

Attachments
Proposed patch (1.15 KB, patch)
2005-06-21 08:47 EDT, Dirk Baeumer CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Baeumer CLA 2005-06-21 08:45:19 EDT 
RC3

The Java element labels class currently creates a log statement if the number of
parameters differ from the number of names. However due to the current nature of
binding keys this happens for all non static inner classes. As a result a log
entry is generated when hovering over the constructor of such classes. 

Since the mismatch of the length of the arrays can't be fixed for 3.1 we decided
to remove the log statement.

For the full details see bug 99137.
Comment 1 Dirk Baeumer CLA 2005-06-21 08:46:54 EDT 
Since generated the log statement happens in the editor (can even happen during
typing) it can really confuse the user. I opt to fix this for RC4.
Comment 2 Dirk Baeumer CLA 2005-06-21 08:47:59 EDT 
Created attachment 23608 [details]
Proposed patch
Comment 3 Dirk Baeumer CLA 2005-06-21 08:48:21 EDT 
Daniel, can you please cast your vote.
Comment 4 Dirk Baeumer CLA 2005-06-21 08:48:38 EDT 
Philippe, can you cast your vote.
Comment 5 Dani Megert CLA 2005-06-21 08:56:06 EDT 
+1 for 3.1 RC4
Comment 6 Philipe Mulet CLA 2005-06-21 11:07:20 EDT 
+1 for RC4
Comment 7 Dirk Baeumer CLA 2005-06-21 11:42:14 EDT 
Fix reviewed by Martin Aeschlimann and Tom Eicher.

Fixed for > 20050621.
Comment 8 Markus Keller CLA 2005-06-22 08:33:39 EDT 
Verified in N20050622-0010.