Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 99635

Summary:	[Preferences] Errors/Warnings page disables "OK" when build cancelled
Product:	[Eclipse Project] Platform	Reporter:	David Saff <david>
Component:	UI	Assignee:	Platform UI Triaged <platform-ui-triaged>
Status:	RESOLVED WORKSFORME	QA Contact:	Oleg Besedin <ob1.eclipse>
Severity:	normal
Priority:	P5	CC:	daniel_megert, eclipse
Version:	3.1	Keywords:	helpwanted
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description David Saff

2005-06-13 09:39:54 EDT

In RC2:

1) Window > Preferences > Java > Compiler > Errors / Warnings
2) Change a preference.
3) Hit "OK"

I now get a warning about having to rebuild my workspace.  Woah--rebuilding my
workspace could take a while.  I want to think harder about whether this is
really what I want to do:

4) Click "Cancel"

The "OK" button is now disabled, and remains disabled even if I change more
options.  I would have expected "OK" to remain enabled, and every time I press
it, I get the same prompt.  If I wanted to forgo building the workspace, I would
have pressed "No" at the warning prompt.

Comment 1 Dirk Baeumer

2005-06-13 18:08:26 EDT

Agree, however not critical. Workaround is to close the dialog and reopen it.

Comment 2 David Saff

2005-06-14 09:03:11 EDT

Agree not critical for 3.1.  However, Dirk's workaround is insufficient: if you
close the dialog, reopen it, and hit OK, no recompile is triggered unless you
change some _other_ setting: the "dirty" bit has been lost for the change made
in comment 0 step 2.

Comment 3 Martin Aeschlimann

2005-06-15 05:17:21 EDT

bug is in platform UI, the error/warnings preference page would allow being
applied again, and doesn't set isValid to false.

The build job is submitted as IWorkbenchPreferenceContainer.registerUpdateJob

Comment 4 Walter Harley

2005-06-29 20:03:51 EDT

*** Bug 102237 has been marked as a duplicate of this bug. ***

Comment 5 Tod Creasey

2007-06-14 13:45:27 EDT

There are currently no plans to work on this although we would be happy to review a patch

Comment 6 Susan McCourt

2009-07-09 19:27:34 EDT

As per http://wiki.eclipse.org/Platform_UI/Bug_Triage_Change_2009

Comment 7 Dani Megert

2009-10-01 08:49:16 EDT

Works for me using 3.5 M2.