Bugzilla – Full Text Bug Listing
| Summary: | [Preferences] Colors and Fonts preference page opens extremely wide due to Java properties file compare text font | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Billy Biggs <billy.biggs> | ||||||
| Component: | UI | Assignee: | Kevin McGuire <Kevin_McGuire> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | Kevin McGuire <Kevin_McGuire> | ||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | daniel_megert, ob1.eclipse, pwebster, tomasz.zarna | ||||||
| Version: | 3.1 | Flags: | Kevin_McGuire:
review+
emoffatt: review+ |
||||||
| Target Milestone: | 3.5 RC1 | ||||||||
| Hardware: | PC | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Billy Biggs
Created attachment 22856 [details]
Screenshot
The page remembers the previous tree state but doesn't attempt to do sensible sizing. Deferring This is by design - it is done this way so that you are able to read without scrolling. Having said that "Java properties file compare text font (defaults to Properties File Editor Text Font)" is pretty long. Moving to compare to see if they can shorten it The "(defaults to Properties File Editor Text Font)" portion of the text appears to be appended by the preference page. Moving back to UI. Man this looks bogus, we should fix it. Changed OS to All since this happens on WinXP too. This affects bug 273047. Let's see if we can fix it in RCs. Created attachment 133950 [details] Patch The fix is similar to the fix for the bug 266018. Q: Why '175' in:
+ data.widthHint = Math.max(175, convertWidthInCharsToPixels(30));
Looks like it might be just a copy (and unintended) of the next line in the source:
data.heightHint = Math.max(175, convertHeightInCharsToPixels(10));
175 is rather narrow and I'm not sure it's needed in practice (the other bug mentioned doesn't do a Math.max).
(In reply to comment #9) > Q: Why '175' in: > + data.widthHint = Math.max(175, > convertWidthInCharsToPixels(30)); The logic was: in a clean Eclipse install that table is almost square, so I guessed that initial desired width == initial desired height, which is currently set to 175. If that is too small feel free to increase it. For the refence, on my computer it shows up with default width of about 300 pixels. I guess any number between, say, 150 and 250 will work well. The exact number is probably not important as the table will resize to fill the dialog. (In reply to comment #10) > (In reply to comment #9) > > Q: Why '175' in: > > + data.widthHint = Math.max(175, > > convertWidthInCharsToPixels(30)); > > The logic was: in a clean Eclipse install that table is almost square, so I > guessed that initial desired width == initial desired height, which is > currently set to 175. > > If that is too small feel free to increase it. For the refence, on my computer > it shows up with default width of about 300 pixels. > > I guess any number between, say, 150 and 250 will work well. The exact number > is probably not important as the table will resize to fill the dialog. Thanks for the explanation. Mostly I wanted to ensure it was intentional and not a copy/paste artifact. I'm approving the patch as is but feel free to change to a larger number if you think it warranted. 175 won't hurt and I think it'd be quite unusual for the case to be triggered anyway. +1 for me...sheesh, for a fix like this how did it stay open for almost 4 years? I'll release patch. Released to assign assigned Verified in RC1 |