Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 98276

Summary: Potential mixed/wrong line delimiters: review the usage of CreateFileChange (and subclasses)
Product: [Eclipse Project] JDT Reporter: Dani Megert <daniel_megert>
Component: UIAssignee: Dirk Baeumer <dirk_baeumer>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: tobias_widmer
Version: 3.1   
Target Milestone: 3.1 RC2   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Dani Megert CLA 2005-06-03 10:17:30 EDT 
3.1 RC1

Review the usage of CreateFileChange (and subclasses) for potential mixed/wrong
line delimiters. For details see bug 97198.
Comment 1 Dirk Baeumer CLA 2005-06-06 04:04:19 EDT 
Inspected the following classes:

- DeleteFileChange: is ok
- ExtractInterfaceProcessor
  o rewriteTypeOccurrences: Tobias, this class takes the contet of the super 
    unit stores it into a document and then assigns the content to the 
    fSuperSource. Is this save (e.g has the source in super unit the line 
    delimiter of the project) ?
- MoveInnerToTopRefactoring: is ok
- CreateCopyOfCompilationUnitChange: is ok since it creates a copy. So the
  line delimiter has to be preserved.
Comment 2 Tobias Widmer CLA 2005-06-06 04:45:54 EDT 
ExtractInterfaceProcessor is save as well: The method createTypeTemplate uses 
the line delimiter of the subtype project
Comment 3 Tobias Widmer CLA 2005-06-10 12:22:06 EDT 
Verified by code inspection using I20050610-0010